-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
R4R: Add indent to JSON of gaiacli key [add|show|list]
#3841
R4R: Add indent to JSON of gaiacli key [add|show|list]
#3841
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3841 +/- ##
===========================================
- Coverage 60.92% 60.92% -0.01%
===========================================
Files 192 192
Lines 14323 14331 +8
===========================================
+ Hits 8727 8731 +4
- Misses 5027 5031 +4
Partials 569 569 |
Codecov Report
@@ Coverage Diff @@
## develop #3841 +/- ##
===========================================
- Coverage 60.94% 60.92% -0.02%
===========================================
Files 192 192
Lines 14346 14337 -9
===========================================
- Hits 8743 8735 -8
+ Misses 5033 5029 -4
- Partials 570 573 +3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this PR make the usage of --indent
consistent across the keys
package. I've noted the two other commands that need to be similarly amended.
Also there needs to be an entry in PENDING.md
for this change as well. Thank you for your contribution!
gaiacli key list
gaiacli key [add|show|list]
gaiacli key [add|show|list]
gaiacli key [add|show|list]
LGTM. Lets get this merged @jackzampolin |
Add indent to JSON of `gaiacli key [add|show|list]` Co-Authored-By: yangyanqing <[email protected]>
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.(
Just print format
)Wrote tests (
Just print format, but I had tested
)Updated relevant documentation (
docs/
)Added entries in
PENDING.md
with issue #rereviewed
Files changed
in the github PR explorerFor Admin Use: