Update Docs from Staging #4019
Merged
Update Docs from Staging #4019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gamarin2
requested review from
cwgoes,
ebuchman,
rigelrozanski and
zramsay
as code owners
Codecov Report
@@ Coverage Diff @@
## release/v0.34.0 #4019 +/- ##
===============================================
Coverage 60% 60%
===============================================
Files 212 212
Lines 15111 15111
===============================================
Hits 9068 9068
Misses 5420 5420
Partials 623 623 |
jackzampolin
approved these changes
Apr 2, 2019
zramsay
approved these changes
Apr 2, 2019
|
I would also include the tiny fix for the join-mainnet.md link to |
This reverts commit e2ae35b.
fedekunze
previously requested changes
Apr 2, 2019
There was a problem hiding this comment.
join-mainnet says:
curl https://raw.githubusercontent.com/cosmos/launch/master/latest/genesis.json > $HOME/.gaiad/config/genesis.json
and should say
curl https://raw.githubusercontent.com/cosmos/launch/master/genesis.json > $HOME/.gaiad/config/genesis.json
Co-Authored-By: jackzampolin <[email protected]>
fedekunze
dismissed
their stale review
ACK, but we'll have to update the docs for the next release to include Tm and SDK changes to the genesis
* title capitalization consistency * Cosmos-Hub -> Cosmos Hub
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update docs to latest
Contains:
Closes #3871 #3406 #4021
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry:
sdkch add [section] [stanza] [message]rereviewed
Files changedin the github PR explorerFor Admin Use: