Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.26.x] Use UTC dates when exporting metacards in CSV format #6501

Merged
merged 1 commit into from
Jan 29, 2021

Conversation

SmithJosh
Copy link
Contributor

What does this PR do?

Normalizes any metacard date attributes to UTC when exporting to a CSV file.

Who is reviewing it?

Select relevant component teams:

@codice/io

How should this be tested?

Export a metacard as a CSV file. Verify that the generated CSV uses UTC dates. For example:
Screen Shot 2021-01-29 at 6 04 11 AM

Any background context you want to provide?

What are the relevant tickets?

Fixes: #____

Screenshots

Checklist:

  • Documentation Updated
  • Update / Add Threat Dragon models
  • Update / Add Unit Tests
  • Update / Add Integration Tests

Notes on Review Process

Please see Notes on Review Process for further guidance on requirements for merging and abbreviated reviews.

Review Comment Legend:

  • ✏️ (Pencil) This comment is a nitpick or style suggestion, no action required for approval. This comment should provide a suggestion either as an in line code snippet or a gist.
  • ❓ (Question Mark) This comment is to gain a clearer understanding of design or code choices, clarification is required but action may not be necessary for approval.
  • ❗ (Exclamation Mark) This comment is critical and requires clarification or action before approval.

@SmithJosh
Copy link
Contributor Author

build now

@cxddfbot
Copy link

Internal build has been started, your results will be available at build completion.

@cxddfbot
Copy link

Build SUCCESS See the job results in legacy Jenkins UI or in Blue Ocean UI.

@vinamartin vinamartin added the 👀 Verified Someone has manually verified that the changes work and there are no regressions. label Jan 29, 2021
@vinamartin
Copy link
Member

Manually verified, LGTM ✅
Screen Shot 2021-01-29 at 10 44 45

@SmithJosh SmithJosh merged commit 8483609 into codice:2.26.x Jan 29, 2021
@SmithJosh SmithJosh deleted the csv-export-utc-dates branch January 29, 2021 17:53
derekwilhelm added a commit to derekwilhelm/ddf that referenced this pull request Aug 18, 2022
alexabird added a commit that referenced this pull request Aug 8, 2024
alexabird added a commit that referenced this pull request Sep 13, 2024
alexabird added a commit that referenced this pull request Sep 13, 2024
malmgrens4 added a commit that referenced this pull request Nov 7, 2024
Forward Ports

Provide better transform failure message 390db3f
#6771

DDF-6386 Add support for source id and metacard type for csv metacard transforms
367e426
#6387

Adds Gmd QueryResponseTransformer
89877a4
#6781

Use UTC dates when exporting metacards in CSV format
27ed601
#6501

Fix CSV transformer output when no columnOrder given
fef3cb1
#6653

Updated the CsvTransformer to remove attributes that have empty or null
fbb2b4d
#6738

Xlsx column filtering
0335485
#6747

updated RTF transformer formatting and now omits null attributes from
64f8e5d
#6744

fix npe in rtf
41fe113
#6750

Updated CSV and XLSX transformers to maintain the order specified in the columnOrder argument
506791d
#6757

Dynamic rtf
83bcf56
#6762

Fix multi-value exports for RTF
dd7bc91
#6767

---------

Co-authored-by: derekwilhelm <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👀 Verified Someone has manually verified that the changes work and there are no regressions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants