-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DDF-6386 Add support for source id and metacard type for csv metacard transforms #6707
Conversation
build now |
Internal build has been started, your results will be available at build completion. |
Build SUCCESS See the job results in legacy Jenkins UI or in Blue Ocean UI. |
...-csv-queryresponse/src/test/java/ddf/catalog/transformer/csv/CsvMetacardTransformerTest.java
Show resolved
Hide resolved
build now |
Internal build has been started, your results will be available at build completion. |
Build SUCCESS See the job results in legacy Jenkins UI or in Blue Ocean UI. |
...ransformer-csv-common/src/main/java/ddf/catalog/transformer/csv/common/MetacardIterator.java
Outdated
Show resolved
Hide resolved
...ransformer-csv-common/src/main/java/ddf/catalog/transformer/csv/common/MetacardIterator.java
Outdated
Show resolved
Hide resolved
...former-csv-common/src/test/java/ddf/catalog/transformer/csv/common/MetacardIteratorTest.java
Outdated
Show resolved
Hide resolved
<dependency> | ||
<groupId>javax.xml.bind</groupId> | ||
<artifactId>jaxb-api</artifactId> | ||
<version>2.2.11</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to be a different version then the version declared in the root pom?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This matches the version that is pulled in indirectly via the platform dependencies. The jaxb version defined in the root pom is not for this dependency, even though you would think that it would be. 🤷
build now |
Internal build has been started, your results will be available at build completion. |
Build SUCCESS See the job results in legacy Jenkins UI or in Blue Ocean UI. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within 7 days. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within 7 days. Thank you for your contributions. |
What does this PR do?
Forward port and conflict resolution of #6387 :
Downstream projects need to create CSV exports that include the source identifier and metacard type name. The current code only supports exporting data that is contained in a metacard attribute. However, the source identifier and metacard type name are stored separately from the attributes.
This PR also creates a constant in MetacardType for the string "metacard-type", which was being defined multiple times in DDF and in downstream projects.
This PR also includes a forward port of #6501 which adds UTC dates when exporting metacards in CSV format.
Who is reviewing it?
@glenhein
@jlcsmith
@jrnorth
Select relevant component teams:
@codice/core-apis
@codice/data
Ask 2 committers to review/merge the PR and tag them here.
@andrewkfiedler
@clockard
How should this be tested?
Build with a downstream project that provides a UI capable of creating a CSV export. The export should include the source id and metacard type. Make sure that the exported data includes the correct values for these fields.
Export a metacard as a CSV file. Verify that the generated CSV uses UTC dates. For example:
Any background context you want to provide?
What are the relevant tickets?
Fixes: #6386
Screenshots
Checklist:
Notes on Review Process
Please see Notes on Review Process for further guidance on requirements for merging and abbreviated reviews.
Review Comment Legend: