[2.26.x] DDF-6386 Add support for source id and metacard type for csv metacard transforms #6387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pklinef
approved these changes
Oct 19, 2020
jlcsmith
approved these changes
Oct 19, 2020
jlcsmith
changed the title
|
Hero successful. Built this with DDF-UI and verified I could export as a CSV using the "Export as" link in the menu next to the metacard title in the inspector view (dropdown in the see screenshot), and that the CSV it generates includes the "source-id" field. The CSV link in the actions tab did not work (on the left in the screenshot - it just creates an empty CSV), but I tested with 2.26.0 and it doesn't work there either, so that's a separate issue.
|
SmithJosh
approved these changes
Oct 27, 2020
4 tasks
4 tasks
malmgrens4
added a commit
that referenced
this pull request
Nov 7, 2024
Forward Ports Provide better transform failure message 390db3f #6771 DDF-6386 Add support for source id and metacard type for csv metacard transforms 367e426 #6387 Adds Gmd QueryResponseTransformer 89877a4 #6781 Use UTC dates when exporting metacards in CSV format 27ed601 #6501 Fix CSV transformer output when no columnOrder given fef3cb1 #6653 Updated the CsvTransformer to remove attributes that have empty or null fbb2b4d #6738 Xlsx column filtering 0335485 #6747 updated RTF transformer formatting and now omits null attributes from 64f8e5d #6744 fix npe in rtf 41fe113 #6750 Updated CSV and XLSX transformers to maintain the order specified in the columnOrder argument 506791d #6757 Dynamic rtf 83bcf56 #6762 Fix multi-value exports for RTF dd7bc91 #6767 --------- Co-authored-by: derekwilhelm <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Downstream projects need to create CSV exports that include the source identifier and metacard type name. The current code only supports exporting data that is contained in a metacard attribute. However, the source identifier and metacard type name are stored separately from the attributes.
This PR also creates a constant in MetacardType for the string "metacard-type", which was being defined multiple times in DDF and in downstream projects.
Who is reviewing it?
@pklinef
@derekwilhelm
Select relevant component teams:
@codice/core-apis
@codice/data
Ask 2 committers to review/merge the PR and tag them here.
@Bdthomson
@jlcsmith
How should this be tested?
Build with a downstream project that provides a UI capable of creating a CSV export. The export should include the source id and metacard type. Make sure that the exported data includes the correct values for these fields.
Any background context you want to provide?
What are the relevant tickets?
Fixes: #6386
Screenshots
Checklist:
Notes on Review Process
Please see Notes on Review Process for further guidance on requirements for merging and abbreviated reviews.
Review Comment Legend: