Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.26.x] Adds Gmd QueryResponseTransformer #6781

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

jlcsmith
Copy link
Member

What does this PR do?

Adds a QueryResponseTransformer implementation for GMD format.

Who is reviewing it?

@derekwilhelm
@birda

How should this be tested?

Any background context you want to provide?

What are the relevant tickets?

Fixes: #____

Screenshots

Checklist:

  • Documentation Updated
  • Update / Add Threat Dragon models
  • Update / Add Unit Tests
  • Update / Add Integration Tests

Notes on Review Process

Please see Notes on Review Process for further guidance on requirements for merging and abbreviated reviews.

Review Comment Legend:

  • ✏️ (Pencil) This comment is a nitpick or style suggestion, no action required for approval. This comment should provide a suggestion either as an in line code snippet or a gist.
  • ❓ (Question Mark) This comment is to gain a clearer understanding of design or code choices, clarification is required but action may not be necessary for approval.
  • ❗ (Exclamation Mark) This comment is critical and requires clarification or action before approval.

@jlcsmith jlcsmith requested a review from bdeining as a code owner March 19, 2024 06:49
@jlcsmith jlcsmith changed the title Adds Gmd QueryResponseTransformer [2.26.x] Adds Gmd QueryResponseTransformer Mar 19, 2024
@alexabird
Copy link
Contributor

build now

@cxddfbot
Copy link

Internal build has been started, your results will be available at build completion.

@Override
public BinaryContent transform(SourceResponse sourceResponse, Map<String, Serializable> map)
throws CatalogTransformerException {
if (sourceResponse.getResults() != null && sourceResponse.getResults().size() == 1) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the GMD Schema itself doesn't appear to support multiple metadata records in a single doc, but a possible improvement here would be to create a zip of all the results in the GMD XML format.

@alexabird
Copy link
Contributor

Deployed these changes in a downstream project and now able to export a single metacard in gmd:MD_Metadata format

@alexabird alexabird added the 👀 Verified Someone has manually verified that the changes work and there are no regressions. label Mar 19, 2024
@cxddfbot
Copy link

Build SUCCESS See the job results in legacy Jenkins UI or in Blue Ocean UI.

@jlcsmith jlcsmith merged commit c879577 into codice:2.26.x Mar 20, 2024
3 checks passed
alexabird pushed a commit that referenced this pull request Aug 7, 2024
alexabird added a commit that referenced this pull request Sep 13, 2024
alexabird added a commit that referenced this pull request Sep 13, 2024
malmgrens4 added a commit that referenced this pull request Nov 7, 2024
Forward Ports

Provide better transform failure message 390db3f
#6771

DDF-6386 Add support for source id and metacard type for csv metacard transforms
367e426
#6387

Adds Gmd QueryResponseTransformer
89877a4
#6781

Use UTC dates when exporting metacards in CSV format
27ed601
#6501

Fix CSV transformer output when no columnOrder given
fef3cb1
#6653

Updated the CsvTransformer to remove attributes that have empty or null
fbb2b4d
#6738

Xlsx column filtering
0335485
#6747

updated RTF transformer formatting and now omits null attributes from
64f8e5d
#6744

fix npe in rtf
41fe113
#6750

Updated CSV and XLSX transformers to maintain the order specified in the columnOrder argument
506791d
#6757

Dynamic rtf
83bcf56
#6762

Fix multi-value exports for RTF
dd7bc91
#6767

---------

Co-authored-by: derekwilhelm <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👀 Verified Someone has manually verified that the changes work and there are no regressions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants