[2.26.x] updated RTF transformer formatting and now omits null attributes from… #6744
Conversation
| @@ -89,6 +89,7 @@ public void setAttributes(List<String> attributes) { | |||
| @Override | |||
| public Map<String, ExportValue> toExportMap(Metacard metacard) { | |||
| return attributes.stream() | |||
| .filter(s -> metacard.getAttribute(s) != null) | |||
There was a problem hiding this comment.
❓Do we want to remove attributes with null/empty values too?
There was a problem hiding this comment.
Yes. This avoids having multiple tables with no data in them as things like "Contact" are often empty.
There was a problem hiding this comment.
Just want to make sure we're on the same page - I'm asking if we need additional checks on the attribute's getValue() for null/empty.
There was a problem hiding this comment.
yeah, probably want to make sure it's not an empty string
glenhein
changed the title
| @@ -89,6 +89,7 @@ public void setAttributes(List<String> attributes) { | |||
| @Override | |||
| public Map<String, ExportValue> toExportMap(Metacard metacard) { | |||
| return attributes.stream() | |||
| .filter(s -> metacard.getAttribute(s) != null) | |||
There was a problem hiding this comment.
yeah, probably want to make sure it's not an empty string
|
I'm starting the hero |
|
The RTF does look a lot better in MS Word. I don't like the right margin because it pushes to the edge of the paper. We probably need feedback between Leidos and @lifenouveau . I'l say the hero is ok for now, since it functions as advertised. 
|
|
It might need a fixed width so the content would wrap instead of extend indefinitely. |
|
The current library doesn't allow us to limit the width of the cells of a table. That may be doable but would likely require refactoring to use a different RTF library all together. |
I'm assuming there isn't a way to force a wrap on long non-space strings like a URL? |
kcwire
force-pushed
the
rtf-attr-filtering
branch
from
34d508b to
02ffdf7
Compare
|
build now |
|
Internal build has been started, your results will be available at build completion. |
|
Build SUCCESS See the job results in legacy Jenkins UI or in Blue Ocean UI. |
Forward Ports Provide better transform failure message 390db3f #6771 DDF-6386 Add support for source id and metacard type for csv metacard transforms 367e426 #6387 Adds Gmd QueryResponseTransformer 89877a4 #6781 Use UTC dates when exporting metacards in CSV format 27ed601 #6501 Fix CSV transformer output when no columnOrder given fef3cb1 #6653 Updated the CsvTransformer to remove attributes that have empty or null fbb2b4d #6738 Xlsx column filtering 0335485 #6747 updated RTF transformer formatting and now omits null attributes from 64f8e5d #6744 fix npe in rtf 41fe113 #6750 Updated CSV and XLSX transformers to maintain the order specified in the columnOrder argument 506791d #6757 Dynamic rtf 83bcf56 #6762 Fix multi-value exports for RTF dd7bc91 #6767 --------- Co-authored-by: derekwilhelm <[email protected]>
… output
What does this PR do?
Updates the RTF Transformers output formatting to include borders around the tables, removes the section breaks between each category, omits null valued attributes or the entire category if no attributes within a category have a value.
Who is reviewing it?
@glenhein
@jrnorth
How should this be tested?
Ingest a some data. Then export the results as RTF via the rest endpoint:
https://localhost:8993/services/catalog/query?q=*&format=rtf
Verify the formatting is updated and null valued attributes are not present.
Checklist:
Review Comment Legend: