-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.26.x] Xlsx column filtering #6747
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
build now |
jlcsmith
approved these changes
Jun 7, 2023
glenhein
approved these changes
Jun 8, 2023
starting hero |
In order to build with downstream projects, I had to add and embed the following to catalog-transformer-xlsx:
After that was resolved, the XSLX output was as expected. |
build now |
Internal build has been started, your results will be available at build completion. |
Build SUCCESS See the job results in legacy Jenkins UI or in Blue Ocean UI. |
jrnorth
approved these changes
Jun 8, 2023
alexabird
added a commit
that referenced
this pull request
Sep 13, 2024
This reverts commit c3b1e34.
alexabird
added a commit
that referenced
this pull request
Sep 13, 2024
This reverts commit c3b1e34.
4 tasks
malmgrens4
added a commit
that referenced
this pull request
Nov 7, 2024
Forward Ports Provide better transform failure message 390db3f #6771 DDF-6386 Add support for source id and metacard type for csv metacard transforms 367e426 #6387 Adds Gmd QueryResponseTransformer 89877a4 #6781 Use UTC dates when exporting metacards in CSV format 27ed601 #6501 Fix CSV transformer output when no columnOrder given fef3cb1 #6653 Updated the CsvTransformer to remove attributes that have empty or null fbb2b4d #6738 Xlsx column filtering 0335485 #6747 updated RTF transformer formatting and now omits null attributes from 64f8e5d #6744 fix npe in rtf 41fe113 #6750 Updated CSV and XLSX transformers to maintain the order specified in the columnOrder argument 506791d #6757 Dynamic rtf 83bcf56 #6762 Fix multi-value exports for RTF dd7bc91 #6767 --------- Co-authored-by: derekwilhelm <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Makes the XLSX transformer filter out empty, null, object, and binary attributes from the resulting xlsx file.
Who is reviewing it?
@glenhein
@jlcsmith
@jrnorth
How should this be tested?
Ingest some data, ideally of varying types. Export as xlsx via the rest endpoint:
https://localhost:8993/services/catalog/query?q=8&format=xlsx
Any background context you want to provide?
This PR is to apply the same logic done for the CSV and RTF transformers.
Checklist:
Notes on Review Process
Please see Notes on Review Process for further guidance on requirements for merging and abbreviated reviews.
Review Comment Legend: