Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.26.x] Xlsx column filtering #6747

Merged
merged 3 commits into from
Jun 9, 2023
Merged

[2.26.x] Xlsx column filtering #6747

merged 3 commits into from
Jun 9, 2023

Conversation

kcwire
Copy link
Member

@kcwire kcwire commented Jun 7, 2023

What does this PR do?

Makes the XLSX transformer filter out empty, null, object, and binary attributes from the resulting xlsx file.

Who is reviewing it?

@glenhein
@jlcsmith
@jrnorth

How should this be tested?

Ingest some data, ideally of varying types. Export as xlsx via the rest endpoint:
https://localhost:8993/services/catalog/query?q=8&format=xlsx

Any background context you want to provide?

This PR is to apply the same logic done for the CSV and RTF transformers.

Checklist:

  • Documentation Updated
  • Update / Add Threat Dragon models
  • Update / Add Unit Tests
  • Update / Add Integration Tests

Notes on Review Process

Please see Notes on Review Process for further guidance on requirements for merging and abbreviated reviews.

Review Comment Legend:

  • ✏️ (Pencil) This comment is a nitpick or style suggestion, no action required for approval. This comment should provide a suggestion either as an in line code snippet or a gist.
  • ❓ (Question Mark) This comment is to gain a clearer understanding of design or code choices, clarification is required but action may not be necessary for approval.
  • ❗ (Exclamation Mark) This comment is critical and requires clarification or action before approval.

@kcwire
Copy link
Member Author

kcwire commented Jun 7, 2023

build now

@glenhein
Copy link
Contributor

glenhein commented Jun 8, 2023

starting hero

@glenhein
Copy link
Contributor

glenhein commented Jun 8, 2023

In order to build with downstream projects, I had to add and embed the following to catalog-transformer-xlsx:

        <dependency>
            <groupId>org.apache.commons</groupId>
            <artifactId>commons-csv</artifactId>
            <version>${commons-csv.version}</version>
        </dependency>

After that was resolved, the XSLX output was as expected.

@kcwire
Copy link
Member Author

kcwire commented Jun 8, 2023

build now

@cxddfbot
Copy link

cxddfbot commented Jun 8, 2023

Internal build has been started, your results will be available at build completion.

@cxddfbot
Copy link

cxddfbot commented Jun 8, 2023

Build SUCCESS See the job results in legacy Jenkins UI or in Blue Ocean UI.

@jrnorth jrnorth merged commit c3b1e34 into 2.26.x Jun 9, 2023
alexabird added a commit that referenced this pull request Aug 8, 2024
alexabird added a commit that referenced this pull request Sep 13, 2024
alexabird added a commit that referenced this pull request Sep 13, 2024
malmgrens4 added a commit that referenced this pull request Nov 7, 2024
Forward Ports

Provide better transform failure message 390db3f
#6771

DDF-6386 Add support for source id and metacard type for csv metacard transforms
367e426
#6387

Adds Gmd QueryResponseTransformer
89877a4
#6781

Use UTC dates when exporting metacards in CSV format
27ed601
#6501

Fix CSV transformer output when no columnOrder given
fef3cb1
#6653

Updated the CsvTransformer to remove attributes that have empty or null
fbb2b4d
#6738

Xlsx column filtering
0335485
#6747

updated RTF transformer formatting and now omits null attributes from
64f8e5d
#6744

fix npe in rtf
41fe113
#6750

Updated CSV and XLSX transformers to maintain the order specified in the columnOrder argument
506791d
#6757

Dynamic rtf
83bcf56
#6762

Fix multi-value exports for RTF
dd7bc91
#6767

---------

Co-authored-by: derekwilhelm <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants