chore(merge): merge storybook 8 feature branch into main
#11631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-design-system/carbon-for-ibm-dotcom into feat/cwc-storybook-7-vite
…arbon-design-system#11337) * fix(build): add custom rollup plugin * fix(build): add the lit parameter to style imports * fix(build): use rollup alias plugin * chore(prettier): prettier * fix(build): add back text nullable file * fix(build): removing the text nullable file * fix(syntax): remove comment from license
* feat(lit): bump up to lit 3 * chore(prettier): format code --------- Co-authored-by: Kenny Lam <[email protected]>
…on-design-system#11372) Co-authored-by: kennylam <[email protected]>
) * chore(skeleton): update skeleton stories to sb v7 * chore(storybook): remove unused var --------- Co-authored-by: kennylam <[email protected]>
…carbon-design-system#11359) Co-authored-by: kennylam <[email protected]>
…m#11353) * chore(progress-bar): update progress-bar stories to sb v7 * chore(progress-bar): remove unused import --------- Co-authored-by: kennylam <[email protected]>
…-system#11577) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
kennylam
changed the title
main into storybook 8 feature branchmain
…design-system#11151) * chore(examples): rename directory to stackblitz * chore(examples): replace the cds to c4d in styles * chore(examples): last fixes * chore(docs): ....more * docs(examples): replace to stackblitz links * chore(examples): remove sandbox files * docs(examples): renamed cds to c4d * fix(toc): updating scss import * fix(readme): use main instead of cwc-v2 * fix(pagination): updating docs --------- Co-authored-by: Jeff Chew <[email protected]>
…design-system#11655) ### Related Ticket(s) Closes carbon-design-system#11654 ### Description Current stackblitz example only renders out the tab titles, no content. Updating the stackblitz with the authoring structure needed to render out the tab content. BEFORE: <img width="1204" alt="Screenshot 2024-03-19 at 10 31 08 AM" src="https://github.com/carbon-design-system/carbon-for-ibm-dotcom/assets/54281166/d07b4523-8572-4eaa-99de-188ed2e83d4c"> NOW:  ### Changelog **Changed** - Update authoring in cdn and index.html files <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
Co-authored-by: Anna Wen <[email protected]>
…m#11639) Closes carbon-design-system#11635 Adds the file extension to the import path for `lit/directives/if-defined.js` to fix issues with some bundlers. **Changed** - Adds the file extension to the import path for `lit/directives/if-defined.js` to fix issues with some bundlers. <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
) Closes carbon-design-system#11268 [Jira ticket](https://jsw.ibm.com/browse/ADCMS-4401) Fixes accessibility issues with Combo-box, and by extension Dropdown. Used both React package (which uses [Downshift](https://www.downshift-js.com/)), and [ARIA APG](https://www.w3.org/WAI/ARIA/apg/patterns/combobox/) as references. Tested with VoiceOver on Mac OS. * Use both dropdown and combo-box components. Ensure there are no regressions for sighted users * Using a screenreader, test both dropdown and combo-box components. Should work well. See [Select-Only Combobox Example](https://www.w3.org/WAI/ARIA/apg/patterns/combobox/examples/combobox-select-only/) and [Editable Combobox With List Autocomplete Example](https://www.w3.org/WAI/ARIA/apg/patterns/combobox/examples/combobox-autocomplete-list/) are great reference examples. * Regression test the Multi select component (it extends the Dropdown component) **Changed** - Improved dropdown and combo-box accessibility. <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
…rbon-design-system#11626) * fix(cdn): emit the CSS grid classes in a new artifact cssgrid.css * fix(grid-cdn): add path to root node_modules --------- Co-authored-by: kennylam <[email protected]> Co-authored-by: Anna Wen <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
**Changed** - update README for `@carbon/web-components` <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
carbon-design-system#11602) ### Related Ticket(s) Closes carbon-design-system#10963 ### Description This PR updates the content switcher to fetch the current content switcher item even when an icon within the item is clicked ### Changelog **New** - `_getCurrentItem` method **Changed** - content-switcher click handler <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
…ign-system#11183) none We made some enhancements to the alpha v2 masthead after we'd integrated its branch into the main C4IBM v2 branch. This PR ports those enhancements over. - **fix(masthead-v2): use more explicit selector in dropdown toggle** (911f802) ([Original PR](carbon-design-system#11084)) - **feat(masthead-v2): add masthead to document flow** (e1debd8) ([Original PR](carbon-design-system#10998)) - **feat(masthead-v2): Minimize CMApp on megamenu open** (c4a06f3) ([Original PR](carbon-design-system#11085)) - **fix(masthead-v2): do not fail if object data does not exist** (c9609f7) ([Original PR](carbon-design-system#11205)) - **fix(masthead-v2): ensure L1 dropdown targets exist** (fc65086) ([Original PR](carbon-design-system#11254)) - **fix(masthead-v2): provide accessible nav label** (f183d25) ([Original PR](carbon-design-system#11269)) - **fix(sticky-header): prevent negative overscroll from hiding stuck elements** (51015ed) ([Original PR](carbon-design-system#11266)) <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
…-system#11597) none Supports rendering the appropriate markup to integrate with all CTA types supported by the IBM Contact Module app (documented here: https://github.ibm.com/live-advisor/cm-app/blob/master/docs/cm-doc.md#calls-to-action). > **Note:** You may need to use Requestly or a similar service to trick the Contact Module into working on a non-ibm.com webpage. I've attached my Requestly override rule below for reference. Visit the [Masthead with L1 deploy preview](https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11597/index.html?path=/story/components-masthead--with-l-1). For each L1 CTA knob option, verify: - The L1 CTA's icon changes. - The Contact Module changes the CTA text - You'll need to open the Story in a new tab to see this in effect. This is a CMApp limitation. - Clicking the CTA activates the Contact Module. For example, setting the CTA type to "scheduler" should open a "Book a meeting" panel. <img width="1029" alt="Screenshot 2024-03-04 at 9 30 01 AM" src="https://github.com/carbon-design-system/carbon-for-ibm-dotcom/assets/12532727/02524ba7-a0fb-41d2-ad18-8512fd815f91"> <img width="1029" alt="Screenshot 2024-03-04 at 9 30 11 AM" src="https://github.com/carbon-design-system/carbon-for-ibm-dotcom/assets/12532727/6cc834b0-90a7-49ea-bc5d-617f57d2b771"> **New** - Adds ability to configure L1 CTA to integrate with each of the supported IBM Contact Module app CTA types. - Creates `<c4d-masthead-l1-cta>` component that renders markup required for Contact Module integrations. **Changed** - Removes `<c4d-masthead-composite>`'s shadow root to enable Contact Module integrations. <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
…ign-system#11589) ### Related Ticket(s) Closes carbon-design-system#11587 ### Description Fixes sticky behavior issue with TOC Dotcom shell at less than lg breakpoint. ### Testing instructions 1. Open the Dotcom shell > Default 2. Scroll the page 3. The Masthead should be sticky until it reaches the TOC, then the masthead should scroll away, while the TOC becomes sticky to the top. 4. Repeat at both `lg` and less than `lg` breakpoints 5. Repeat 1-4 with the Dotcom shell > With ToC horizontal story ### Changelog **Changed** - TOC dotcom shell sticky behavior fixed at less than lg breakpoint <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
kennylam
force-pushed
the
chore/sb8-main-merge
branch
from
31ead76
to
28cc386
Compare
Now that CSS logical properties are used throughout the project, there is no need for `rtl` artifacts to be built. This PR removes those builds.
**New**
- {{new thing}}
**Changed**
- {{changed thing}}
**Removed**
- remove `rtl` builds and artifacts
- remove Storybook `rtl` documentation
<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
…-system#11618) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
…n-design-system#11495) carbon-design-system/carbon#15634 Removes Stackblitz iframes from Carbon web components Storybook to remove unapproved cookies. **New** - {{new thing}} **Changed** - {{changed thing}} **Removed** - Stackblitz iframes from cwc Storybook <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
kennylam
force-pushed
the
chore/sb8-main-merge
branch
from
28cc386
to
4cace14
Compare
Closes carbon-design-system#10375 This removes local linting packages in favor of hosted ones. **New** - add `eslint-config-carbon` and `stylelint-config-carbon` linting packages **Changed** - update styles to use CSS logical properties - update lint configs - `packages/storybook-images` folder moved to `packages/web-components/.storybook/` - various configs moved to package.json and standalone files removed **Removed** - local lint packages removed - `eslint-config-ibmdotcom` - `eslint-plugin-ibmdotcom-import-rules` - `eslint-plugin-react-prop-type-comments` - `stylelint-config-ibmdotcom` <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
This removes unneeded `rtl` documentation and dependencies. **New** **Removed** - `rtl` deps and docs <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
…ctor (carbon-design-system#11252) Resolves carbon-design-system#11251 This PR mostly refactors masthead source code to be more maintainable and removes dead code. Other than the style fixes, it should result in no visible changes to the masthead. - Makes necessary functions available to Sass stylesheets to fix style regressions. - Removes Cloud-specific masthead styles. --- - Deprecates `MastheadProfileContent` type. - Deprecates `Translation.mastheadNav` in favor of `Translation.masthead.nav`. - Deprecates `Translation.profileMenu` in favor of `Translation.masthead.profileMenu`. - Removes references to v1 data structures that are no longer in use. --- - Deprecates the `navLinks` Masthead Composite property in favor of the more descriptive `l0Data` property. - Splits out the Masthead Composite's main `render` method into more digestible render methods per logical section. - Untangles the knot that was the `renderNavItems` method by providing dedicated `renderTopNav` and `renderLeftNav` methods for the desktop and mobile experiences. - Extracts distinct chunks of logic into their own methods for readability and in some cases reuse across the newly split render methods. - Removes Cloud-specific masthead. - Removes non-functional `customNavLinks` property. Use `l0Data` or `l1Data` instead. - Removes masthead v1's leftover CTA functionality.
…-dotcom into chore/sb8-main-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merges
mainbranch into Storybook 8 feature branchChangelog
New
Changed
Removed