fix(combobox): fix import path for some bundlers #11639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4olivei
added
bug
m4olivei
requested review from
ariellalgilmore,
annawen1 and
jkaeser
and removed request for
a team
m4olivei
referenced
this pull request
Mar 15, 2024
### Related Ticket(s) Closes #11268 [Jira ticket](https://jsw.ibm.com/browse/ADCMS-4401) ### Description Fixes accessibility issues with Combo-box, and by extension Dropdown. Used both React package (which uses [Downshift](https://www.downshift-js.com/)), and [ARIA APG](https://www.w3.org/WAI/ARIA/apg/patterns/combobox/) as references. Tested with VoiceOver on Mac OS. ### Testing * Use both dropdown and combo-box components. Ensure there are no regressions for sighted users * Using a screenreader, test both dropdown and combo-box components. Should work well. See [Select-Only Combobox Example](https://www.w3.org/WAI/ARIA/apg/patterns/combobox/examples/combobox-select-only/) and [Editable Combobox With List Autocomplete Example](https://www.w3.org/WAI/ARIA/apg/patterns/combobox/examples/combobox-autocomplete-list/) are great reference examples. * Regression test the Multi select component (it extends the Dropdown component) ### Changelog **Changed** - Improved dropdown and combo-box accessibility. <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
|
Deploy preview created for package Built with commit: f7f77bf510ac18a10c95eb2c608485778fd259b7 |
|
Deploy preview created for package Built with commit: f7f77bf510ac18a10c95eb2c608485778fd259b7 |
|
Deploy preview created for package Built with commit: f7f77bf510ac18a10c95eb2c608485778fd259b7 |
|
Deploy preview created for package Built with commit: f7f77bf510ac18a10c95eb2c608485778fd259b7 |
2 tasks
ariellalgilmore
approved these changes
Mar 19, 2024
kennylam
added
the
Ready to merge
kodiakhq
bot
merged commit 5c491a0
into
carbon-design-system:main
13 of 14 checks passed
kennylam
pushed a commit
to kennylam/carbon-for-ibm-dotcom
that referenced
this pull request
Mar 20, 2024
…m#11639) Closes carbon-design-system#11635 Adds the file extension to the import path for `lit/directives/if-defined.js` to fix issues with some bundlers. **Changed** - Adds the file extension to the import path for `lit/directives/if-defined.js` to fix issues with some bundlers. <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
|
Hey there! This issue/pull request was referenced in recently released v2.6.0. |
kennylam
pushed a commit
to kennylam/carbon-for-ibm-dotcom
that referenced
this pull request
Jun 11, 2024
…m#11639) ### Related Ticket(s) Closes carbon-design-system#11635 ### Description Adds the file extension to the import path for `lit/directives/if-defined.js` to fix issues with some bundlers. ### Changelog **Changed** - Adds the file extension to the import path for `lit/directives/if-defined.js` to fix issues with some bundlers. <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket(s)
Closes #11635
Description
Adds the file extension to the import path for
lit/directives/if-defined.jsto fix issues with some bundlers.Changelog
Changed
lit/directives/if-defined.jsto fix issues with some bundlers.