fix(build): add rollup plugin to switch out .scss?lit during build #11337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview created for package Built with commit: 97993b44b186d7a7a08cce20c0bc67a1a40121b7 |
kennylam
reviewed
Jan 5, 2024
packages/carbon-web-components/.storybook/knob-text-nullable.ts
Outdated
Show resolved
Hide resolved
annawen1
requested review from
emyarod and
IgnacioBecerra
and removed request for
a team
kennylam
approved these changes
Jan 8, 2024
annawen1
merged commit d471864
into
carbon-design-system:feat/cwc-storybook-7-vite
7 of 14 checks passed
kennylam
pushed a commit
to kennylam/carbon-for-ibm-dotcom
that referenced
this pull request
Jun 11, 2024
…arbon-design-system#11337) * fix(build): add custom rollup plugin * fix(build): add the lit parameter to style imports * fix(build): use rollup alias plugin * chore(prettier): prettier * fix(build): add back text nullable file * fix(build): removing the text nullable file * fix(syntax): remove comment from license
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket(s)
Closes #11347
Description
Currently the CWC build fails due to the vite requiring a parameter added to the style imports (ie.
./button.scss?lit). This PR uses the@rollup/plugin-aliasplugin to point the style imports to the corresponding scss file during build.This PR also updates the
babel-plugin-resource-js-paths.jsfile to swap out.scss?litimports to the generated.css.jsfile in the es buildChangelog
New
@rollup/plugin-aliasto direct the style imports with the?litquery param to the corresponding scss fileChanged
babel-plugin-resource-js-paths.jsfile to look for.scss?litimports