Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[carbon-web-components]: Update build for CWC to account for vite style imports #11347

Closed
Tracked by #11258
annawen1 opened this issue Jan 8, 2024 · 0 comments · Fixed by #11337
Closed
Tracked by #11258

[carbon-web-components]: Update build for CWC to account for vite style imports #11347

annawen1 opened this issue Jan 8, 2024 · 0 comments · Fixed by #11337

Comments

@annawen1
Copy link
Member

annawen1 commented Jan 8, 2024 •
edited
Loading

Currently the CWC build (and subsquently Dotcom Web Components) fails due to the Vite requiring a parameter added to the style imports (ie. ./button.scss?lit).
@annawen1 annawen1 mentioned this issue Jan 8, 2024
Closed
@annawen1 annawen1 changed the title update build for CWC to account for vite style imports [carbon-web-components]: Update build for CWC to account for vite style imports Jan 8, 2024
@annawen1 annawen1 moved this to Review in Carbon for IBM.com Jan 8, 2024
@annawen1 annawen1 mentioned this issue Jan 8, 2024
Merged
@annawen1 annawen1 linked a pull request Jan 8, 2024 that will close this issue
fix(build): add rollup plugin to switch out .scss?lit during build #11337
Merged
@github-project-automation github-project-automation bot moved this from Review to Done in Carbon for IBM.com Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Carbon for IBM.com
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(build): add rollup plugin to switch out .scss?lit during build annawen1/carbon-for-ibm-dotcom
1 participant
@annawen1