Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lint]: Remove local lint packages in favor of published package #10375

Closed
Tracked by #10368
, #11191
...
kennylam opened this issue Apr 21, 2023 · 0 comments · Fixed by #11248
Closed
Tracked by #10368
, #11191
...

[lint]: Remove local lint packages in favor of published package #10375

kennylam opened this issue Apr 21, 2023 · 0 comments · Fixed by #11248
Assignees
@kennylam
Labels
dependencies Pull requests that update a dependency file v2

Comments

@kennylam
Copy link
Member

kennylam commented Apr 21, 2023 •
edited
Loading

Remove local lint packages in favor of published packages, e.g. eslint-config-carbon. Can also take the opportunity to consolidate and remove duplicate eslint configs.
@kennylam kennylam mentioned this issue Apr 21, 2023
Closed
@kennylam kennylam added v2 dependencies Pull requests that update a dependency file labels Apr 21, 2023
@kennylam kennylam moved this to Backlog in Carbon for IBM.com Apr 21, 2023
@kennylam kennylam changed the title Remove local lint packages in favor of published package, e.g. [eslint-config-carbon](https://www.npmjs.com/package/eslint-config-carbon) [lint]: Remove local lint packages in favor of published package May 2, 2023
@kennylam kennylam self-assigned this Nov 13, 2023
@kennylam kennylam moved this from Backlog to Doing in Carbon for IBM.com Nov 13, 2023
@kennylam kennylam mentioned this issue Nov 13, 2023
Closed
@kennylam kennylam mentioned this issue Dec 5, 2023
Closed
This was referenced Dec 14, 2023
Closed
Merged
@kennylam kennylam moved this from Doing to Review in Carbon for IBM.com Dec 21, 2023
@kodiakhq kodiakhq bot closed this as completed in #11248 Dec 21, 2023
@github-project-automation github-project-automation bot moved this from Review to Done in Carbon for IBM.com Dec 21, 2023
kodiakhq bot pushed a commit that referenced this issue Dec 21, 2023
@kennylam
chore(deps): update linting packages (#11248)
72142f0 
### Related Ticket(s)

Closes #10375

### Description

This removes local linting packages in favor of hosted ones.

### Changelog

**New**

- add `eslint-config-carbon` and `stylelint-config-carbon` linting packages

**Changed**

- update styles to use CSS logical properties
- update lint configs
- `packages/storybook-images` folder moved to `packages/web-components/.storybook/`
- various configs moved to package.json and standalone files removed

**Removed**
- local lint packages removed
  - `eslint-config-ibmdotcom`
  - `eslint-plugin-ibmdotcom-import-rules`
  - `eslint-plugin-react-prop-type-comments`
  - `stylelint-config-ibmdotcom`

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
kennylam added a commit to kennylam/carbon-for-ibm-dotcom that referenced this issue Jan 5, 2024
@kennylam
chore(deps): update linting packages (carbon-design-system#11248)
45000a2 
Closes carbon-design-system#10375

This removes local linting packages in favor of hosted ones.

**New**

- add `eslint-config-carbon` and `stylelint-config-carbon` linting packages

**Changed**

- update styles to use CSS logical properties
- update lint configs
- `packages/storybook-images` folder moved to `packages/web-components/.storybook/`
- various configs moved to package.json and standalone files removed

**Removed**
- local lint packages removed
  - `eslint-config-ibmdotcom`
  - `eslint-plugin-ibmdotcom-import-rules`
  - `eslint-plugin-react-prop-type-comments`
  - `stylelint-config-ibmdotcom`

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
kennylam added a commit to kennylam/carbon-for-ibm-dotcom that referenced this issue Mar 12, 2024
@kennylam
chore(deps): update linting packages (carbon-design-system#11248)
e51d2f8 
Closes carbon-design-system#10375

This removes local linting packages in favor of hosted ones.

**New**

- add `eslint-config-carbon` and `stylelint-config-carbon` linting packages

**Changed**

- update styles to use CSS logical properties
- update lint configs
- `packages/storybook-images` folder moved to `packages/web-components/.storybook/`
- various configs moved to package.json and standalone files removed

**Removed**
- local lint packages removed
  - `eslint-config-ibmdotcom`
  - `eslint-plugin-ibmdotcom-import-rules`
  - `eslint-plugin-react-prop-type-comments`
  - `stylelint-config-ibmdotcom`

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
kennylam added a commit to kennylam/carbon-for-ibm-dotcom that referenced this issue Mar 21, 2024
@kennylam
chore(deps): update linting packages (carbon-design-system#11248)
870b04a 
Closes carbon-design-system#10375

This removes local linting packages in favor of hosted ones.

**New**

- add `eslint-config-carbon` and `stylelint-config-carbon` linting packages

**Changed**

- update styles to use CSS logical properties
- update lint configs
- `packages/storybook-images` folder moved to `packages/web-components/.storybook/`
- various configs moved to package.json and standalone files removed

**Removed**
- local lint packages removed
  - `eslint-config-ibmdotcom`
  - `eslint-plugin-ibmdotcom-import-rules`
  - `eslint-plugin-react-prop-type-comments`
  - `stylelint-config-ibmdotcom`

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
kennylam added a commit to kennylam/carbon-for-ibm-dotcom that referenced this issue Jun 11, 2024
@kennylam
chore(deps): update linting packages (carbon-design-system#11248)
0290f52 
### Related Ticket(s)

Closes carbon-design-system#10375

### Description

This removes local linting packages in favor of hosted ones.

### Changelog

**New**

- add `eslint-config-carbon` and `stylelint-config-carbon` linting packages

**Changed**

- update styles to use CSS logical properties
- update lint configs
- `packages/storybook-images` folder moved to `packages/web-components/.storybook/`
- various configs moved to package.json and standalone files removed

**Removed**
- local lint packages removed
  - `eslint-config-ibmdotcom`
  - `eslint-plugin-ibmdotcom-import-rules`
  - `eslint-plugin-react-prop-type-comments`
  - `stylelint-config-ibmdotcom`

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kennylam kennylam

Labels
dependencies Pull requests that update a dependency file v2
Projects
Carbon for IBM.com
Archived in project
Milestone
No milestone
1 participant
@kennylam