Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): remove local lint packages #11229

Closed
wants to merge 15 commits into from
Closed

chore(deps): remove local lint packages #11229

wants to merge 15 commits into from

Conversation

kennylam
Copy link
Member

@kennylam kennylam commented Dec 14, 2023 •
edited
Loading

Related Ticket(s)

Closes #10375

Description

This removes local linting packages in favor of hosted ones.

Changelog

New

  • add eslint-config-carbon and stylelint-config-carbon linting packages

Changed

  • update styles to use CSS logical properties
  • update lint configs
  • packages/storybook-images folder moved to packages/web-components/.storybook/
  • various configs moved to package.json and standalone files removed

Removed

  • local lint packages removed
    • eslint-config-ibmdotcom
    • eslint-plugin-ibmdotcom-import-rules
    • eslint-plugin-react-prop-type-comments
    • stylelint-config-ibmdotcom

@kennylam kennylam requested a review from a team as a code owner December 14, 2023 00:30
@kennylam kennylam requested review from ariellalgilmore and sangeethababu9223 and removed request for a team December 14, 2023 00:30
@kennylam kennylam changed the title Chore/remove local linting packages chore(deps): remove local lint packages Dec 14, 2023
@kennylam kennylam marked this pull request as draft December 16, 2023 14:35
@kennylam kennylam mentioned this pull request Dec 18, 2023
Merged
@kennylam kennylam force-pushed the chore/remove-local-linting-packages branch from 1718bf0 to a87af6c Compare December 19, 2023 09:16
@kennylam kennylam force-pushed the chore/remove-local-linting-packages branch 2 times, most recently from 3b9fa5b to ec48a38 Compare December 19, 2023 10:11
@kennylam kennylam force-pushed the chore/remove-local-linting-packages branch from ec48a38 to 52d9c0f Compare December 19, 2023 10:19
@kennylam kennylam closed this Dec 20, 2023
@kennylam kennylam deleted the chore/remove-local-linting-packages branch January 19, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ariellalgilmore ariellalgilmore Awaiting requested review from ariellalgilmore ariellalgilmore is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@sangeethababu9223 sangeethababu9223 Awaiting requested review from sangeethababu9223 sangeethababu9223 is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[lint]: Remove local lint packages in favor of published package
1 participant
@kennylam