Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(slider): update story to Storybook v7 #11374

Conversation

m4olivei
Copy link
Contributor

@m4olivei m4olivei commented Jan 9, 2024

Related Ticket(s)

Closes #11373

Description

Adjustments to slider component stories to be compatible with Storybook v7.

Changelog

Changed

  • Updated slider Storybook stories for Storybook v7

@m4olivei m4olivei requested a review from a team as a code owner January 9, 2024 19:21
@m4olivei m4olivei requested review from emyarod and IgnacioBecerra and removed request for a team January 9, 2024 19:21
@ibmdotcom-bot
Copy link
Contributor

@m4olivei
Copy link
Contributor Author

m4olivei commented Jan 9, 2024

This one, like #11361 , has style issues that look like they are fixed upstream in main. See comment there #11361 (comment)

Copy link
Member

@kennylam kennylam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Slider styles fixed in #11285 like you mentioned.

@kennylam kennylam merged commit 24f8cd0 into carbon-design-system:feat/cwc-storybook-7-vite Jan 10, 2024
7 of 14 checks passed
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants