Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(radio-button): update radio-button stories to sb v7 #11361

Merged
merged 3 commits into from
Jan 18, 2024
Merged

chore(radio-button): update radio-button stories to sb v7 #11361

merged 3 commits into from
Jan 18, 2024

Conversation

m4olivei
Copy link
Contributor

@m4olivei m4olivei commented Jan 8, 2024

Related Ticket(s)

Closes #11355

Description

Adjustments to radio-button component stories to be compatible with Storybook v7.

Changelog

Changed

  • Updated radio-button Storybook stories for Storybook v7

@m4olivei m4olivei requested a review from a team as a code owner January 8, 2024 19:26
@m4olivei m4olivei requested review from ariellalgilmore and annawen1 and removed request for a team January 8, 2024 19:26
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 8, 2024 •
edited
Loading

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11361/index.html

Built with commit: 80b2dcc47dbf628944f77504be8a38149002f570

@m4olivei
Copy link
Contributor Author

m4olivei commented Jan 8, 2024

I'm not sure why, but something is off with the styles here:

image

Nothing explicitly changes with the styles here, so this is confusing to me. I'll conver this one to a draft and come back to it later.

@m4olivei m4olivei marked this pull request as draft January 8, 2024 20:31
@m4olivei
Copy link
Contributor Author

m4olivei commented Jan 9, 2024

I spent some time trying to narrow down the style differences by comparing between main and here. I suspect it has something to do with dependencies differences. I'm going to leave this one until we can merge changes from main upstream to the feature branch and then into this branch to look at it again.

@m4olivei m4olivei mentioned this pull request Jan 9, 2024
Merged
@m4olivei m4olivei force-pushed the chore/radio-button-sb-v7 branch from 0357a29 to 4a48a20 Compare January 10, 2024 20:26
@kennylam kennylam mentioned this pull request Jan 11, 2024
Closed
@m4olivei m4olivei marked this pull request as ready for review January 12, 2024 14:32
@m4olivei
Copy link
Contributor Author

Per my last comment, I think the styling issue here should be fixed upstream, so I'll mark this as Ready for Review.

kennylam
kennylam approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@kennylam kennylam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11361/index.html

Built with commit: 80b2dcc47dbf628944f77504be8a38149002f570

@kennylam kennylam merged commit 722a84e into carbon-design-system:feat/cwc-storybook-7-vite Jan 18, 2024
8 of 13 checks passed
kennylam added a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Jun 11, 2024
@m4olivei @kennylam
chore(radio-button): update radio-button stories to sb v7 (carbon-des…
2d67d83 
…ign-system#11361)

Co-authored-by: kennylam <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennylam kennylam kennylam approved these changes

@ariellalgilmore ariellalgilmore Awaiting requested review from ariellalgilmore ariellalgilmore is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@annawen1 annawen1 Awaiting requested review from annawen1 annawen1 is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
package: carbon web components storybook-7
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@m4olivei @ibmdotcom-bot @kennylam