Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[form-group]: incorrect styling for radio and submit buttons #11393

Closed
kennylam opened this issue Jan 11, 2024 · 2 comments
Closed

[form-group]: incorrect styling for radio and submit buttons #11393

kennylam opened this issue Jan 11, 2024 · 2 comments
Labels
bug Something isn't working dev Needs some dev work package: carbon web components

Comments

@kennylam
Copy link
Member

kennylam commented Jan 11, 2024

The radio button styles are missing right margin spacing and the submit button is the wrong width (shouldn't be 100% of the container.

image

image

Originally posted by @kennylam in #11361 (comment)

@kennylam kennylam added bug Something isn't working dev Needs some dev work package: carbon web components labels Jan 11, 2024
@kennylam kennylam moved this to Backlog in Carbon for IBM.com Jan 11, 2024
@m4olivei
Copy link
Contributor

Are radio buttons broken on v2? I'm looking here, and they look OK to me:

https://carbon-design-system.github.io/carbon-for-ibm-dotcom/v2/carbon-web-components-v2/?path=/story/components-radio-button--default

image

I think my comment in the SB v7 PR, was due to the feat/cwc-storybook-7-vite branch being behind main, not that the style was broken on main.

@kennylam
Copy link
Member Author

Radio buttons look fine in main yeah. I just put it in this issue to double check once the SB7 work gets merged in.

@andy-blum andy-blum closed this as not planned Won't fix, can't repro, duplicate, stale Dec 11, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in Carbon for IBM.com Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dev Needs some dev work package: carbon web components
Projects
Status: Done
Development

No branches or pull requests

3 participants