Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(slider): sizing issues #11285

Conversation

ariellalgilmore
Copy link
Member

@ariellalgilmore ariellalgilmore commented Jan 2, 2024

Related Ticket(s)

Closes #11272

Description

{{Add a human-readable description / detail summary of what the PR is changing and any details around how and why}}

{{If applicable, include a screenshot indicating an example or examples of what the PR is changing in the application}}

Changelog

New

  • {{new thing}}

Changed

  • {{changed thing}}

Removed

  • {{removed thing}}

@ariellalgilmore ariellalgilmore marked this pull request as ready for review January 2, 2024 16:20
@ariellalgilmore ariellalgilmore requested a review from a team as a code owner January 2, 2024 16:20
@annawen1 annawen1 linked an issue Jan 2, 2024 that may be closed by this pull request
2 tasks
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 2, 2024

Copy link
Member

@annawen1 annawen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 2, 2024

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 2, 2024

@ariellalgilmore ariellalgilmore added the Ready to merge Label for the pull requests that are ready to merge label Jan 2, 2024
@kodiakhq kodiakhq bot merged commit a3967fa into carbon-design-system:release-cwc/v2.1.1 Jan 2, 2024
6 of 9 checks passed
@ariellalgilmore ariellalgilmore deleted the fix/slider-circle branch January 2, 2024 18:25
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Mar 12, 2024
### Related Ticket(s)

Closes carbon-design-system#11272 

### Description

{{Add a human-readable description / detail summary of what the PR is changing and any details around how and why}}

{{If applicable, include a screenshot indicating an example or examples of what the PR is changing in the application}}

### Changelog

**New**

- {{new thing}}

**Changed**

- {{changed thing}}

**Removed**

- {{removed thing}}

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Jun 11, 2024
### Related Ticket(s)

Closes carbon-design-system#11272 

### Description

{{Add a human-readable description / detail summary of what the PR is changing and any details around how and why}}

{{If applicable, include a screenshot indicating an example or examples of what the PR is changing in the application}}

### Changelog

**New**

- {{new thing}}

**Changed**

- {{changed thing}}

**Removed**

- {{removed thing}}

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

slider pointer styles
3 participants