Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(toc): adjust mobile selector, should always be navbar #11589

Merged
merged 9 commits into from
Mar 12, 2024
Merged

fix(toc): adjust mobile selector, should always be navbar #11589

merged 9 commits into from
Mar 12, 2024

Conversation

m4olivei
Copy link
Contributor

@m4olivei m4olivei commented Feb 27, 2024 •
edited
Loading

Related Ticket(s)

Closes #11587

Description

Fixes sticky behavior issue with TOC Dotcom shell at less than lg breakpoint.

Testing instructions

  1. Open the Dotcom shell > Default
  2. Scroll the page
  3. The Masthead should be sticky until it reaches the TOC, then the masthead should scroll away, while the TOC becomes sticky to the top.
  4. Repeat at both lg and less than lg breakpoints
  5. Repeat 1-4 with the Dotcom shell > With ToC horizontal story

Changelog

Changed

  • TOC dotcom shell sticky behavior fixed at less than lg breakpoint

@m4olivei m4olivei added bug Something isn't working dev Needs some dev work package: web components Work necessary for the IBM.com Library web components package owner: Innovation Team used when the engineering work will be done by Hybrid Cloud with DDS engineers as consultants v2 labels Feb 27, 2024
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 27, 2024 •
edited
Loading

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11589/index.html

Built with commit: e881f6e71764bab795c30d38592cdb2f690064ff

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 27, 2024 •
edited
Loading

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11589/index.html

Built with commit: e881f6e71764bab795c30d38592cdb2f690064ff

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 27, 2024 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11589/index.html

Built with commit: e881f6e71764bab795c30d38592cdb2f690064ff

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 27, 2024 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11589/index.html

Built with commit: e881f6e71764bab795c30d38592cdb2f690064ff

@m4olivei m4olivei marked this pull request as ready for review February 27, 2024 18:07
@m4olivei m4olivei requested a review from a team as a code owner February 27, 2024 18:07
@m4olivei m4olivei requested review from ariellalgilmore, annawen1, jkaeser, bruno-amorim, marcelojcs and andy-blum and removed request for a team February 27, 2024 18:07
@m4olivei m4olivei mentioned this pull request Mar 5, 2024
Merged
jkaeser
jkaeser approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@jkaeser jkaeser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! One small nit is that this selector is used in two places now, and there's an opportunity to store it in a variable with a nice descriptive name.

annawen1
annawen1 approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@annawen1 annawen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@annawen1 annawen1 added the Ready to merge Label for the pull requests that are ready to merge label Mar 6, 2024
@kodiakhq kodiakhq bot merged commit 0393906 into carbon-design-system:main Mar 12, 2024
12 of 20 checks passed
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Mar 20, 2024
@m4olivei @kennylam
fix(toc): adjust mobile selector, should always be navbar (carbon-des…
e8bcc23 
…ign-system#11589)

### Related Ticket(s)

Closes carbon-design-system#11587

### Description

Fixes sticky behavior issue with TOC Dotcom shell at less than lg breakpoint.

### Testing instructions

1. Open the Dotcom shell > Default
2. Scroll the page
3. The Masthead should be sticky until it reaches the TOC, then the masthead should scroll away, while the TOC becomes sticky to the top.
4. Repeat at both `lg` and less than `lg` breakpoints
5. Repeat 1-4 with the Dotcom shell > With ToC horizontal  story

### Changelog

**Changed**

- TOC dotcom shell sticky behavior fixed at less than lg breakpoint

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
@github-actions GitHub Actions
Copy link
Contributor

Hey there! This issue/pull request was referenced in recently released v2.6.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annawen1 annawen1 annawen1 approved these changes

@andy-blum andy-blum andy-blum approved these changes

@jkaeser jkaeser jkaeser approved these changes

@ariellalgilmore ariellalgilmore Awaiting requested review from ariellalgilmore ariellalgilmore is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@bruno-amorim bruno-amorim Awaiting requested review from bruno-amorim

@marcelojcs marcelojcs Awaiting requested review from marcelojcs

Assignees
No one assigned
Labels
bug Something isn't working dev Needs some dev work owner: Innovation Team used when the engineering work will be done by Hybrid Cloud with DDS engineers as consultants package: web components Work necessary for the IBM.com Library web components package Ready to merge Label for the pull requests that are ready to merge v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TOC v2]: Table of contents in Dotcom shell is hidden behind masthead on less than lg breakpoint
5 participants
@m4olivei @ibmdotcom-bot @jkaeser @andy-blum @annawen1