Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ALF error screen #7135

Merged
merged 1 commit into from
Dec 17, 2024
Merged

ALF error screen #7135

merged 1 commit into from
Dec 17, 2024

Conversation

mozzius
Copy link
Member

@mozzius mozzius commented Dec 17, 2024

Before After
Simulator Screenshot - iPhone 16 - 2024-12-17 at 00 00 38 Simulator Screenshot - iPhone 16 - 2024-12-16 at 23 59 16
Before After
Simulator Screenshot - iPhone 16 - 2024-12-17 at 00 00 52 Simulator Screenshot - iPhone 16 - 2024-12-16 at 23 59 40

@arcalinea arcalinea temporarily deployed to samuel/alf-error-screen - social-app PR #7135 December 17, 2024 00:02 — with Render Destroyed
@github-actions GitHub Actions
Copy link

Old size New size Diff
6.78 MB 6.78 MB -248 B (-0.00%)

gaearon
gaearon approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm if you tested all web breakpoints

estrattonbailey
estrattonbailey approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@estrattonbailey estrattonbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep should be good 👍 nice one

@mozzius mozzius merged commit be33c62 into main Dec 17, 2024
6 checks passed
@mozzius mozzius deleted the samuel/alf-error-screen branch December 17, 2024 00:11
drash-course added a commit to drash-course/social-app that referenced this pull request Dec 18, 2024
@drash-course
Merge branch 'main' into idn-handles
e98df45 
* main: (58 commits)
  Fix tests
  Layout tweaks (bluesky-social#7150)
  Trending (Beta) (bluesky-social#7144)
  Fix emoji picker position (bluesky-social#7146)
  Tweak Follow dialog Search placeholder (bluesky-social#7147)
  New progress guide - 10 follows (bluesky-social#7128)
  Pipe statsig events to logger (bluesky-social#7141)
  Fix notifications borders (bluesky-social#7140)
  Refetch empty feed on focus (bluesky-social#7139)
  Read storage on window.onstorage (bluesky-social#7137)
  [ELI5] Tweak wording on the signup screen (bluesky-social#7136)
  alf error screen (bluesky-social#7135)
  add safe area view to profile error screen (bluesky-social#7134)
  Adjust gates (bluesky-social#7132)
  disable automaticallAdjustsScrollIndicatorInsets (bluesky-social#7131)
  Bump more native deps (bluesky-social#7129)
  Update more Expo packages (bluesky-social#7127)
  feat: widen recent search profile link for mobile devices (bluesky-social#7119)
  Fix video uploads on native (bluesky-social#7126)
  Fix post time localization on Android (bluesky-social#6742)
  ...

# Conflicts:
#	src/view/com/profile/ProfileSubpageHeader.tsx
#	src/view/screens/ProfileList.tsx
Signez pushed a commit to Signez/bsky-social-app that referenced this pull request Dec 26, 2024
@mozzius @Signez
alf error screen (bluesky-social#7135)
08fe959
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estrattonbailey estrattonbailey estrattonbailey approved these changes

@gaearon gaearon gaearon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mozzius @gaearon @estrattonbailey @arcalinea