Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New progress guide - 10 follows #7128

Merged
merged 47 commits into from
Dec 17, 2024
Merged

New progress guide - 10 follows #7128

merged 47 commits into from
Dec 17, 2024

Conversation

mozzius
Copy link
Member

@mozzius mozzius commented Dec 16, 2024 •
edited
Loading

  • new progress guide: follow 10 people
  • new dialog to try and get people to follow more people
Screen.Recording.2024-12-16.at.16.09.23.mov

Test plan

Add yourself to the statsig gate. Reset onboarding state, go through onboarding and select some interests

Observe the new progress guide

Make sure the dialog works on all platforms. Try selecting tabs, searching, following etc

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 16, 2024 •
edited
Loading

Old size New size Diff
6.78 MB 6.8 MB 17.3 KB (0.25%)

@mozzius mozzius force-pushed the samuel/new-progressguide branch from a645fee to 8524b9d Compare December 16, 2024 21:53
@arcalinea arcalinea temporarily deployed to samuel/new-progressguide - social-app PR #7128 December 16, 2024 21:53 — with Render Destroyed
@arcalinea arcalinea temporarily deployed to samuel/new-progressguide - social-app PR #7128 December 16, 2024 22:07 — with Render Destroyed
@arcalinea arcalinea temporarily deployed to samuel/new-progressguide - social-app PR #7128 December 16, 2024 22:15 — with Render Destroyed
@mozzius mozzius marked this pull request as ready for review December 16, 2024 22:16
@mozzius mozzius force-pushed the samuel/new-progressguide branch from daeb310 to a8accdd Compare December 16, 2024 22:17
@arcalinea arcalinea temporarily deployed to samuel/new-progressguide - social-app PR #7128 December 16, 2024 22:17 — with Render Destroyed
@arcalinea arcalinea temporarily deployed to samuel/new-progressguide - social-app PR #7128 December 17, 2024 16:32 — with Render Destroyed
@arcalinea arcalinea temporarily deployed to samuel/new-progressguide - social-app PR #7128 December 17, 2024 16:35 — with Render Destroyed
@arcalinea arcalinea temporarily deployed to samuel/new-progressguide - social-app PR #7128 December 17, 2024 16:39 — with Render Destroyed
@arcalinea arcalinea temporarily deployed to samuel/new-progressguide - social-app PR #7128 December 17, 2024 16:47 — with Render Destroyed
@arcalinea arcalinea temporarily deployed to samuel/new-progressguide - social-app PR #7128 December 17, 2024 16:52 — with Render Destroyed
@arcalinea arcalinea temporarily deployed to samuel/new-progressguide - social-app PR #7128 December 17, 2024 16:54 — with Render Destroyed
@arcalinea arcalinea temporarily deployed to samuel/new-progressguide - social-app PR #7128 December 17, 2024 17:01 — with Render Destroyed
@arcalinea arcalinea temporarily deployed to samuel/new-progressguide - social-app PR #7128 December 17, 2024 17:08 — with Render Destroyed
@gaearon gaearon merged commit 0cbb03c into main Dec 17, 2024
6 checks passed
@gaearon gaearon deleted the samuel/new-progressguide branch December 17, 2024 17:13
@knotbin
Copy link
Contributor

knotbin commented Dec 17, 2024

How are these accounts chosen? Is there an algorithm or is it all manual?

auroursa added a commit to auroursa/bsky-app-zh that referenced this pull request Dec 18, 2024
@auroursa
Translated bluesky-social#7128
bcc050d
@gaearon
Copy link
Collaborator

gaearon commented Dec 18, 2024

these are just top search matches, no manual selection. the matches in search are ranked according to something similar to PageRank

drash-course added a commit to drash-course/social-app that referenced this pull request Dec 18, 2024
@drash-course
Merge branch 'main' into idn-handles
e98df45 
* main: (58 commits)
  Fix tests
  Layout tweaks (bluesky-social#7150)
  Trending (Beta) (bluesky-social#7144)
  Fix emoji picker position (bluesky-social#7146)
  Tweak Follow dialog Search placeholder (bluesky-social#7147)
  New progress guide - 10 follows (bluesky-social#7128)
  Pipe statsig events to logger (bluesky-social#7141)
  Fix notifications borders (bluesky-social#7140)
  Refetch empty feed on focus (bluesky-social#7139)
  Read storage on window.onstorage (bluesky-social#7137)
  [ELI5] Tweak wording on the signup screen (bluesky-social#7136)
  alf error screen (bluesky-social#7135)
  add safe area view to profile error screen (bluesky-social#7134)
  Adjust gates (bluesky-social#7132)
  disable automaticallAdjustsScrollIndicatorInsets (bluesky-social#7131)
  Bump more native deps (bluesky-social#7129)
  Update more Expo packages (bluesky-social#7127)
  feat: widen recent search profile link for mobile devices (bluesky-social#7119)
  Fix video uploads on native (bluesky-social#7126)
  Fix post time localization on Android (bluesky-social#6742)
  ...

# Conflicts:
#	src/view/com/profile/ProfileSubpageHeader.tsx
#	src/view/screens/ProfileList.tsx
pfrazee pushed a commit that referenced this pull request Dec 18, 2024
@auroursa
Update Chinese & Cantonese localization (#6839)
8f17145 
* Update translates from crowdin

* zh-CN: Improved translations

* Both: Improved translations

* TW & HK: Improved translations

* CN: Re-translate 'Quote posts enabled'

* TW: Improved translations

* CN: Unify the translations of 'label'

* CN: Fix grammar

* CN & HK: Improved translation

* TW: Improved translations

* Update translates from crowdin

* Translated new Layout & Improved zh-TW translations

* zh-CN: Unified label translation

* zh-HK: Fix translation

* zh-TW: Improved translation

* Update from crowdin

* Improved translation

* Update translates from crowdin

* Update from crowdin

* Update the latest translations

* Update translations according #7065

* zh-TW: Improved translations

* Update translates from crowdin

* zh-HK: Improved translations

* Update translates from crowdin

* Improved translations

* zh-CN & zh-HK: Improved translations

* zh-CN: Re-translated 'Bluesky is better with friends!'

* Update translates from crowdin

* Translated #7128

* Remove placeholder

* Translated #7144 #7147

* Improved translations

* Improved translations#2

* zh-CN: Improved translations
Signez pushed a commit to Signez/bsky-social-app that referenced this pull request Dec 26, 2024
@mozzius @surfdude29
@gaearon @Signez
New progress guide - 10 follows (bluesky-social#7128)
1543e50 
* new follow-10 progress guide

* find follows dialog

* wip tabs

* flatlist version with search

* hardcode out jake gold

* lazy load followup suggestions

* Update src/components/ProgressGuide/FollowDialog.tsx

Co-authored-by: surfdude29 <[email protected]>

* comment out replacing, enable paging

* rm autofocus

* find shadow profiles in paginated search

* clear search when press tabs

* better tab a11y

* fix label

* adjust scroll indicator insets

* do the same scroll indicator adjustment for searchable people list

* hardcode jake to just be 'tech'

* Retain state on close/reopen

* only change follow btn color when not followed

* add guide to inside dialog

* fix task alignment

* Enable contextual suggestions

* WIP: show multiple suggestions

* Rework so it animates well

* Show more items

* remove card style

* move tabs to own component

* split out header top

* scroll active tab into view

* rm log

* Improve perf a bit

* boost popular interests over alphabetical ones

* scroll active tab into view

* revert back to round buttons

* Fix overrenders of the tab bar items

* Fix unintended animation

* Scroll initial into view if needed

* Unlift state, the dialog thing breaks lifting

* Persist simply

* Fix empty state

* Fix incorrect gate exposure

* Fix another bad useGate

* Nit

---------

Co-authored-by: surfdude29 <[email protected]>
Co-authored-by: Dan Abramov <[email protected]>
Signez pushed a commit to Signez/bsky-social-app that referenced this pull request Dec 26, 2024
@auroursa @Signez
Update Chinese & Cantonese localization (bluesky-social#6839)
b94eac3 
* Update translates from crowdin

* zh-CN: Improved translations

* Both: Improved translations

* TW & HK: Improved translations

* CN: Re-translate 'Quote posts enabled'

* TW: Improved translations

* CN: Unify the translations of 'label'

* CN: Fix grammar

* CN & HK: Improved translation

* TW: Improved translations

* Update translates from crowdin

* Translated new Layout & Improved zh-TW translations

* zh-CN: Unified label translation

* zh-HK: Fix translation

* zh-TW: Improved translation

* Update from crowdin

* Improved translation

* Update translates from crowdin

* Update from crowdin

* Update the latest translations

* Update translations according bluesky-social#7065

* zh-TW: Improved translations

* Update translates from crowdin

* zh-HK: Improved translations

* Update translates from crowdin

* Improved translations

* zh-CN & zh-HK: Improved translations

* zh-CN: Re-translated 'Bluesky is better with friends!'

* Update translates from crowdin

* Translated bluesky-social#7128

* Remove placeholder

* Translated bluesky-social#7144 bluesky-social#7147

* Improved translations

* Improved translations#2

* zh-CN: Improved translations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surfdude29 surfdude29 surfdude29 left review comments

@gaearon gaearon gaearon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mozzius @knotbin @gaearon @surfdude29 @arcalinea