Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable automaticallyAdjustsScrollIndicatorInsets #7131

Merged

Conversation

mozzius
Copy link
Member

@mozzius mozzius commented Dec 16, 2024

iOS automatically adds in the safe area to the scroll indicator insets, even though the overwhelming majority of our ScrollViews do not stretch from edge to edge. we should just disable this behaviour by default

Can't take screenshots rn but you can see on the testflight that the scroll indicators on the post thread screen doesn't go all the way to the top. this PR fixes that

@arcalinea arcalinea temporarily deployed to samuel/disable-automaticallyadjustscrollindicatorinsets - social-app PR #7131 December 16, 2024 21:51 — with Render Destroyed
@mozzius mozzius force-pushed the samuel/disable-automaticallyadjustscrollindicatorinsets branch from 09ad41c to 0e60434 Compare December 16, 2024 21:52
@arcalinea arcalinea temporarily deployed to samuel/disable-automaticallyadjustscrollindicatorinsets - social-app PR #7131 December 16, 2024 21:52 — with Render Destroyed
Copy link

Old size New size Diff
6.78 MB 6.78 MB 0 B (0.00%)

@gaearon gaearon merged commit c339dc5 into main Dec 16, 2024
6 checks passed
@gaearon gaearon deleted the samuel/disable-automaticallyadjustscrollindicatorinsets branch December 16, 2024 22:23
drash-course added a commit to drash-course/social-app that referenced this pull request Dec 18, 2024
* main: (58 commits)
  Fix tests
  Layout tweaks (bluesky-social#7150)
  Trending (Beta) (bluesky-social#7144)
  Fix emoji picker position (bluesky-social#7146)
  Tweak Follow dialog Search placeholder (bluesky-social#7147)
  New progress guide - 10 follows (bluesky-social#7128)
  Pipe statsig events to logger (bluesky-social#7141)
  Fix notifications borders (bluesky-social#7140)
  Refetch empty feed on focus (bluesky-social#7139)
  Read storage on window.onstorage (bluesky-social#7137)
  [ELI5] Tweak wording on the signup screen (bluesky-social#7136)
  alf error screen (bluesky-social#7135)
  add safe area view to profile error screen (bluesky-social#7134)
  Adjust gates (bluesky-social#7132)
  disable automaticallAdjustsScrollIndicatorInsets (bluesky-social#7131)
  Bump more native deps (bluesky-social#7129)
  Update more Expo packages (bluesky-social#7127)
  feat: widen recent search profile link for mobile devices (bluesky-social#7119)
  Fix video uploads on native (bluesky-social#7126)
  Fix post time localization on Android (bluesky-social#6742)
  ...

# Conflicts:
#	src/view/com/profile/ProfileSubpageHeader.tsx
#	src/view/screens/ProfileList.tsx
Signez pushed a commit to Signez/bsky-social-app that referenced this pull request Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants