feat: widen recent search profile link for mobile devices #7119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
reviewed
Dec 16, 2024
src/view/screens/Search/Search.tsx
Outdated
| style={styles.profilePressable}> | ||
| style={[ | ||
| styles.profilePressable, | ||
| isMobile && styles.profilePressableMobile, |
There was a problem hiding this comment.
Is there a downside to make this style unconditional?
There was a problem hiding this comment.
It's okay to apply style to all screen sizes. I just pushed the change
gaearon
approved these changes
Dec 16, 2024
drash-course
added a commit
to drash-course/social-app
that referenced
this pull request
Dec 18, 2024
* main: (58 commits) Fix tests Layout tweaks (bluesky-social#7150) Trending (Beta) (bluesky-social#7144) Fix emoji picker position (bluesky-social#7146) Tweak Follow dialog Search placeholder (bluesky-social#7147) New progress guide - 10 follows (bluesky-social#7128) Pipe statsig events to logger (bluesky-social#7141) Fix notifications borders (bluesky-social#7140) Refetch empty feed on focus (bluesky-social#7139) Read storage on window.onstorage (bluesky-social#7137) [ELI5] Tweak wording on the signup screen (bluesky-social#7136) alf error screen (bluesky-social#7135) add safe area view to profile error screen (bluesky-social#7134) Adjust gates (bluesky-social#7132) disable automaticallAdjustsScrollIndicatorInsets (bluesky-social#7131) Bump more native deps (bluesky-social#7129) Update more Expo packages (bluesky-social#7127) feat: widen recent search profile link for mobile devices (bluesky-social#7119) Fix video uploads on native (bluesky-social#7126) Fix post time localization on Android (bluesky-social#6742) ... # Conflicts: # src/view/com/profile/ProfileSubpageHeader.tsx # src/view/screens/ProfileList.tsx
Signez
pushed a commit
to Signez/bsky-social-app
that referenced
this pull request
Dec 26, 2024
…cial#7119) * feat: widen recent search profile link for mobile devices * chore: apply style to non-mobile screens
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
In response to issue #7111, I prepared a solution to set width of profile links' text in "Recent Searches" to 100% for mobile devices. Change does not affect current profiles layout. Below I place before and after screenshots.
I tested it on Chrome 131.0.6778.140 and Firefox 133.0.3 as problem appeared on web version for screens with width smaller than 900px.
Before:
After:
Greetings
Karol