Adjust gates #7132
Merged
Adjust gates #7132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcalinea
temporarily deployed
to
gates - social-app PR #7132
Render
Destroyed
gaearon
commented
Dec 16, 2024
| const isDiscoverDebugUser = | ||
| IS_INTERNAL || DISCOVER_DEBUG_DIDS[currentAccount?.did ?? ''] | ||
| const gate = useGate() | ||
| const isDiscoverDebugUser = IS_INTERNAL || gate('debug_show_feedcontext') |
There was a problem hiding this comment.
intentionally || here
haileyok
approved these changes
Dec 16, 2024
|
drash-course
added a commit
to drash-course/social-app
that referenced
this pull request
Dec 18, 2024
* main: (58 commits) Fix tests Layout tweaks (bluesky-social#7150) Trending (Beta) (bluesky-social#7144) Fix emoji picker position (bluesky-social#7146) Tweak Follow dialog Search placeholder (bluesky-social#7147) New progress guide - 10 follows (bluesky-social#7128) Pipe statsig events to logger (bluesky-social#7141) Fix notifications borders (bluesky-social#7140) Refetch empty feed on focus (bluesky-social#7139) Read storage on window.onstorage (bluesky-social#7137) [ELI5] Tweak wording on the signup screen (bluesky-social#7136) alf error screen (bluesky-social#7135) add safe area view to profile error screen (bluesky-social#7134) Adjust gates (bluesky-social#7132) disable automaticallAdjustsScrollIndicatorInsets (bluesky-social#7131) Bump more native deps (bluesky-social#7129) Update more Expo packages (bluesky-social#7127) feat: widen recent search profile link for mobile devices (bluesky-social#7119) Fix video uploads on native (bluesky-social#7126) Fix post time localization on Android (bluesky-social#6742) ... # Conflicts: # src/view/com/profile/ProfileSubpageHeader.tsx # src/view/screens/ProfileList.tsx
Signez
pushed a commit
to Signez/bsky-social-app
that referenced
this pull request
Dec 26, 2024
* Remove dead gate * Adjust gates * No need to disable exposures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few things:
DISCOVER_DEBUG_DIDSstuff. It sucks because it's not visible in production.debug_subscriptionsanddebug_show_feedcontextIS_INTERNALis also true (we never want it in public builds)Basically the goal is to get rid of this hardcoded list.
Test Plan
Probably easiest to test by going to an alt, verifying it has no feed feedback or app icon, then allowlisting it in each gate, and verifying both things show up. Note that feed context also shows up for
IS_INTERNALso you'll want to comment that check out before testing.