Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert PR 3013 (Support unary '+' operators for strings) from BABEL_4_4_STABLE #3281

Conversation

robverschoor
Copy link
Contributor

Description

PR 3013 incorrectly ended up in BABEL_4_4_STABLE.

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

thephantomthief and others added 15 commits October 23, 2024 18:46
This commit includes the following changes:
- Disable TDS fault injection flag and tests
- Update DEFAULT_BRANCH to point to stable branch
- Update workflows to point to stable branch

Signed-off-by: Sharu Goel <[email protected]>
…l#3053)

This pull request updates the schedule file in the BABEL_4_X_DEV branch for version 15_9. The change involves replacing the schedule file "BABEL-2736-before-16_5" with "BABEL-2736" to align with the latest version in the 3x DEV branch.

Changes made:

In file: /babelfish_extensions/test/JDBC/upgrade/15_9/schedule
Changed "BABEL-2736-before-16_5" to "BABEL-2736"
Reason for change:
To maintain consistency with the latest version in the 3x DEV branch, which uses "BABEL-2736".

Reference PR: babelfish-for-postgresql#3044
Signed-off-by: Rahul Parande <[email protected]>
To obtain the collation related metadata information of a table returning function we were using sp_describe_first_result_set till now. This procedure also returns the system_type_id (oid) of the datatype, which can change (but not an actual issue). As we only aim to obtain the collation related info, updated the test in such a way to obtain expected columns.

###Issues Resolved
test_db_collation

Signed-off-by: Shameem Ahmed [email protected]
…st file. (babelfish-for-postgresql#3074) (babelfish-for-postgresql#3087)

As daylight saving period ends minute difference between 'UTC' and 'US/Pacific' is changed from 420 to 480. So changed the time zone from 'US/Pacific' to 'Asia/Kolkata' making it independent from daylight saving period.

Issues Resolved
getdate tests were failing because of this issue.

Task: No-JIRA

Signed-off-by: yashneet vinayak <[email protected]>
…postgresql#3084)

* use PG_CATALOG.RIGHT in upgrade scripts to mVU issues (babelfish-for-postgresql#3079)

use PG_CATALOG.RIGHT in upgrade scripts to fix mVU issues

Signed-off-by: Anikait Agrawal <[email protected]>
Signed-off-by: Rohit Bhagat <[email protected]>
Co-authored-by: Rohit Bhagat <[email protected]>
…3101)

Earlier we were not assigning value for loginInfo->username in case of
AD session.

This commit assigns value for loginInfo->username when GSS enabled.

Task: BABEL-5380

Signed-off-by: ANJU BHARTI <[email protected]>
…tatements (babelfish-for-postgresql#3131) (babelfish-for-postgresql#3132)

This commit resolves the syntax error issue that occurs when using '[primary]' as a column name in DML and DDL statements.

Task: BABEL-5422
Issue: babelfish-for-postgresql#3127

Signed-off-by: Sumit Jaiswal [email protected]
…lfish-for-postgresql#3145)

* Update default branch from BABEL_4_4_STABLE__PG_16_5 to BABEL_4_4_STABLE__PG_16_6.  
* Update versions from 14.14, 15.9 and 16.5 to 14.15, 15.10 and 16.6 respectively in upgrade-test-configuration.
* Rename 14_14/schedule file to 14_15/schedule and 15_9/schedule file to 15_10/schedule.
* Bump Babelfish internal version from 16.5 to 16.6.

Task: OSS-ONLY
Signed-off-by: Rishabh Tanwar <[email protected]>
Co-authored-by: RUI LUO <[email protected]>
babelfish-for-postgresql#3088) (babelfish-for-postgresql#3156)

Previously, a guest users always remain member of a login even if login has a mapped
user in a particular database. Due to this any database user is able to access the
objects which are accessible to guest user which is undesirable.

Fixed this issue by only keeping one user member of a login at a time, which means,
guest will be a member of login only if there is no mapped user to that login otherwise
only that mapped user will be a member of login.

Task: BABEL-5389

Co-authored-by: Rishabh Tanwar <[email protected]>
Signed-off-by: Shalini Lohia <[email protected]>
…for-postgresql#3178)

When truncating certain Babelfish catalogs, we use the
heap_truncate_one_rel function which expects the caller to hold the
AccessExclusiveLock on the catalog.

This commit updates the lock used for opening/closing the catalog from
RowExclusiveLock to AccessExclusiveLock.

Task: BABEL-5439

Signed-off-by: Sharu Goel <[email protected]>
(cherry picked from commit 4ad36c5)
Signed-off-by: Tanzeel Khan <[email protected]>
(cherry picked from commit 28e5e7610f09cc008f69be21d60f63e9518765bc)
(cherry picked from commit 834f91f)
Signed-off-by: Roshan Kanwar <[email protected]>
(cherry picked from commit 7c8ac53)
After recent engine fixes, setting of role started giving expected output in case of parallel query enabled environment. This commit updates those test files expected output in case of parallel query enabled run.

Issues Resolved
Task: BABEL-5425

Authored-by: Harsh Lunagariya [email protected]
(cherry picked from commit 8b26542)
@robverschoor robverschoor deleted the revert-1924 branch December 18, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.