Block cross-db 'SELECT ... INTO table FROM ...' statement #2744

HarshLunagariya · 2024-07-16T09:45:50Z

Description

Before this commit, Cross-db 'SELECT ... INTO table FROM ...' was allowed to be executed unintentionally since it was missed to be blocked when cross-db DMLs got supported. Due to this unblocked behaviour, It creates a table whose owner is current session's login since internally cross-db statement execution sets current role to current session's login.

This commit blocks cross-db 'SELECT ... INTO table FROM ...' statement by adding relevant check on ANTLR parser.

Task: BABEL-4934
Signed-off-by: Harsh Lunagariya [email protected]

Issues Resolved

BABEL-4934

Test Scenarios Covered

Use case based -
SELECT INTO query with table within same-db/cross-db
SELECT INTO temp table query
Boundary conditions -
NA
Arbitrary inputs -
NA
Negative test cases -
SELECT INTO query with table within same-db
Minor version upgrade tests -
NA
Major version upgrade tests -
NA
Performance tests -
NA
Tooling impact -
NA
Client tests -

Check List

Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Before this commit, Cross-db 'SELECT ... INTO table FROM ...' was allowed to be executed unintentionally since it was missed to be blocked when cross-db DMLs got supported. Due to this unblocked behaviour, It creates a table whose owner is current session's login since internally cross-db statement execution sets current role to current session's login. This commit blocks cross-db 'SELECT ... INTO table FROM ...' statement by adding relavant check on ANTLR parser. Signed-off-by: Harsh Lunagariya <[email protected]>

…_sel_into

coveralls · 2024-07-16T10:25:53Z

Pull Request Test Coverage Report for Build 10056627748

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
188 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.008%) to 73.218%

Files with Coverage Reduction	New Missed Lines	%
contrib/babelfishpg_tsql/src/pltsql_bulkcopy.c	23	88.33%
contrib/babelfishpg_tsql/src/hooks.c	165	79.69%

Totals
Change from base Build 9952949997:	0.008%
Covered Lines:	42905
Relevant Lines:	58599

💛 - Coveralls

Signed-off-by: Harsh Lunagariya <[email protected]>

forestkeeper

LGTM

shah-nirmit · 2024-07-18T12:41:54Z

contrib/babelfishpg_tsql/src/tsqlIface.cpp

+			{
+				throw PGErrorWrapperException(ERROR,
+						ERRCODE_FEATURE_NOT_SUPPORTED,
+						"cross-db 'SELECT INTO' statement is not supported in Babelfish",


Nit: Should we suggest a alternative in error hint?

error hint will only be logged in logfile. not sure how will it help in this case

Included workaround in comment message itself as suggested by Alex.

Signed-off-by: Harsh Lunagariya <[email protected]>

…for-postgresql#2744) Before this commit, Cross-db 'SELECT ... INTO table FROM ...' was allowed to be executed unintentionally since it was missed to be blocked when cross-db DMLs got supported. Due to this unblocked behaviour, It creates a table whose owner is current session's login since internally cross-db statement execution sets current role to current session's login. This commit blocks cross-db 'SELECT ... INTO table FROM ...' statement by adding relevant check on ANTLR parser. Task: BABEL-4934 Signed-off-by: Harsh Lunagariya [email protected]

) Before this commit, Cross-db 'SELECT ... INTO table FROM ...' was allowed to be executed unintentionally since it was missed to be blocked when cross-db DMLs got supported. Due to this unblocked behaviour, It creates a table whose owner is current session's login since internally cross-db statement execution sets current role to current session's login. This commit blocks cross-db 'SELECT ... INTO table FROM ...' statement by adding relevant check on ANTLR parser. Task: BABEL-4934 Signed-off-by: Harsh Lunagariya [email protected]

…for-postgresql#2744) Before this commit, Cross-db 'SELECT ... INTO table FROM ...' was allowed to be executed unintentionally since it was missed to be blocked when cross-db DMLs got supported. Due to this unblocked behaviour, It creates a table whose owner is current session's login since internally cross-db statement execution sets current role to current session's login. This commit blocks cross-db 'SELECT ... INTO table FROM ...' statement by adding relevant check on ANTLR parser. Task: BABEL-4934 Signed-off-by: Harsh Lunagariya [email protected]

…for-postgresql#2744) (babelfish-for-postgresql#2780) Before this commit, Cross-db 'SELECT ... INTO table FROM ...' was allowed to be executed unintentionally since it was missed to be blocked when cross-db DMLs got supported. Due to this unblocked behaviour, It creates a table whose owner is current session's login since internally cross-db statement execution sets current role to current session's login. This commit blocks cross-db 'SELECT ... INTO table FROM ...' statement by adding relevant check on ANTLR parser. Task: BABEL-4934 Signed-off-by: Harsh Lunagariya [email protected]

…belfish-for-postgresql#2744)" This reverts commit 1570cc6.

…belfish-for-postgresql#2744) (babelfish-for-postgresql#2780)" This reverts commit 0b401ee.

…belfish-for-postgresql#2744)" This reverts commit 1570cc6.

…belfish-for-postgresql#2744) (babelfish-for-postgresql#2780)" This reverts commit 0b401ee.

)" (#3109) This reverts commit 1570cc6. Task: BABEL-4934 Co-authored-by: ANJU BHARTI <[email protected]>

)" (#3112) This reverts commit 1570cc6. Task: BABEL-4934 Co-authored-by: ANJU BHARTI <[email protected]>

)" (#3111) This reverts commit 1570cc6. Task: BABEL-4934 Co-authored-by: ANJU BHARTI <[email protected]>

) (#2780)" (#3114) This reverts commit 0b401ee. Task: BABEL-4934 Signed-off-by: ANJU BHARTI <[email protected]>

) (#2780)" (#3113) This reverts commit 0b401ee. Task: BABEL-4934 Signed-off-by: ANJU BHARTI <[email protected]>

) (#2780)" (#3110) This reverts commit 1570cc6. Task: BABEL-4934 Signed-off-by: ANJU BHARTI <[email protected]>

…belfish-for-postgresql#2744)" (babelfish-for-postgresql#3109) This reverts commit 1570cc6. Task: BABEL-4934 Co-authored-by: ANJU BHARTI <[email protected]>

)" (#3109) This reverts commit 1570cc6. Task: BABEL-4934 Co-authored-by: ANJU BHARTI <[email protected]>

HarshLunagariya and others added 2 commits July 16, 2024 09:41

Merge branch 'babelfish-for-postgresql:BABEL_4_X_DEV' into babel_4934…

529d332

…_sel_into

HarshLunagariya added 2 commits July 16, 2024 18:42

empty commit

637d21c

empty commit

290f480

Signed-off-by: Harsh Lunagariya <[email protected]>

forestkeeper previously approved these changes Jul 18, 2024

View reviewed changes

shah-nirmit approved these changes Jul 19, 2024

View reviewed changes

Deepesh125 previously approved these changes Jul 19, 2024

View reviewed changes

add test

dfbc593

Signed-off-by: Harsh Lunagariya <[email protected]>

HarshLunagariya dismissed stale reviews from Deepesh125 and forestkeeper via dfbc593 July 23, 2024 09:18

Update errmsg

74b718a

Signed-off-by: Harsh Lunagariya <[email protected]>

shah-nirmit approved these changes Jul 23, 2024

View reviewed changes

rishabhtanwar29 approved these changes Jul 23, 2024

View reviewed changes

shardgupta approved these changes Jul 24, 2024

View reviewed changes

shardgupta merged commit 1570cc6 into babelfish-for-postgresql:BABEL_4_X_DEV Jul 24, 2024
43 checks passed

shardgupta deleted the babel_4934_sel_into branch July 24, 2024 06:43

anju15bharti pushed a commit to amazon-aurora/babelfish_extensions that referenced this pull request Nov 13, 2024

Revert "Block cross-db 'SELECT ... INTO table FROM ...' statement (ba…

8b72a5f

…belfish-for-postgresql#2744)" This reverts commit 1570cc6.

anju15bharti pushed a commit to amazon-aurora/babelfish_extensions that referenced this pull request Nov 13, 2024

Revert "Block cross-db 'SELECT ... INTO table FROM ...' statement (ba…

c6c43a7

…belfish-for-postgresql#2744) (babelfish-for-postgresql#2780)" This reverts commit 0b401ee.

anju15bharti pushed a commit to amazon-aurora/babelfish_extensions that referenced this pull request Nov 13, 2024

Revert "Block cross-db 'SELECT ... INTO table FROM ...' statement (ba…

b59d5db

…belfish-for-postgresql#2744)" This reverts commit 1570cc6.

anju15bharti pushed a commit to amazon-aurora/babelfish_extensions that referenced this pull request Nov 13, 2024

Revert "Block cross-db 'SELECT ... INTO table FROM ...' statement (ba…

b8ca0c9

…belfish-for-postgresql#2744)" This reverts commit 1570cc6.

anju15bharti pushed a commit to amazon-aurora/babelfish_extensions that referenced this pull request Nov 13, 2024

Revert "Block cross-db 'SELECT ... INTO table FROM ...' statement (ba…

9802968

…belfish-for-postgresql#2744) (babelfish-for-postgresql#2780)" This reverts commit 0b401ee.

anju15bharti pushed a commit to amazon-aurora/babelfish_extensions that referenced this pull request Nov 13, 2024

Revert "Block cross-db 'SELECT ... INTO table FROM ...' statement (ba…

9cd8a04

…belfish-for-postgresql#2744) (babelfish-for-postgresql#2780)" This reverts commit 0b401ee.

anju15bharti pushed a commit to amazon-aurora/babelfish_extensions that referenced this pull request Nov 13, 2024

Revert "Block cross-db 'SELECT ... INTO table FROM ...' statement (ba…

b1d086e

…belfish-for-postgresql#2744) (babelfish-for-postgresql#2780)" This reverts commit 0b401ee.

anju15bharti pushed a commit to amazon-aurora/babelfish_extensions that referenced this pull request Nov 13, 2024

Revert "Block cross-db 'SELECT ... INTO table FROM ...' statement (ba…

b9d7a05

…belfish-for-postgresql#2744) (babelfish-for-postgresql#2780)" This reverts commit 0b401ee.

shardgupta pushed a commit that referenced this pull request Nov 13, 2024

Revert "Block cross-db 'SELECT ... INTO table FROM ...' statement (#2744

bc28d09

)" (#3109) This reverts commit 1570cc6. Task: BABEL-4934 Co-authored-by: ANJU BHARTI <[email protected]>

shardgupta pushed a commit that referenced this pull request Nov 13, 2024

Revert "Block cross-db 'SELECT ... INTO table FROM ...' statement (#2744

8a5decd

)" (#3112) This reverts commit 1570cc6. Task: BABEL-4934 Co-authored-by: ANJU BHARTI <[email protected]>

shardgupta pushed a commit that referenced this pull request Nov 13, 2024

Revert "Block cross-db 'SELECT ... INTO table FROM ...' statement (#2744

bc50a31

)" (#3111) This reverts commit 1570cc6. Task: BABEL-4934 Co-authored-by: ANJU BHARTI <[email protected]>

shardgupta pushed a commit that referenced this pull request Nov 13, 2024

Revert "Block cross-db 'SELECT ... INTO table FROM ...' statement (#2744

a124d83

) (#2780)" (#3114) This reverts commit 0b401ee. Task: BABEL-4934 Signed-off-by: ANJU BHARTI <[email protected]>

shardgupta pushed a commit that referenced this pull request Nov 13, 2024

Revert "Block cross-db 'SELECT ... INTO table FROM ...' statement (#2744

6348816

) (#2780)" (#3113) This reverts commit 0b401ee. Task: BABEL-4934 Signed-off-by: ANJU BHARTI <[email protected]>

shardgupta pushed a commit that referenced this pull request Nov 13, 2024

Revert "Block cross-db 'SELECT ... INTO table FROM ...' statement (#2744

b8d05b9

) (#2780)" (#3110) This reverts commit 1570cc6. Task: BABEL-4934 Signed-off-by: ANJU BHARTI <[email protected]>

shardgupta pushed a commit that referenced this pull request Nov 25, 2024

Revert "Block cross-db 'SELECT ... INTO table FROM ...' statement (#2744

8a4fe0a

)" (#3109) This reverts commit 1570cc6. Task: BABEL-4934 Co-authored-by: ANJU BHARTI <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Block cross-db 'SELECT ... INTO table FROM ...' statement #2744

Block cross-db 'SELECT ... INTO table FROM ...' statement #2744

HarshLunagariya commented Jul 16, 2024 •

edited

Loading

coveralls commented Jul 16, 2024 •

edited

Loading

forestkeeper left a comment

shah-nirmit Jul 18, 2024

Deepesh125 Jul 19, 2024

HarshLunagariya Jul 23, 2024

Block cross-db 'SELECT ... INTO table FROM ...' statement #2744

Block cross-db 'SELECT ... INTO table FROM ...' statement #2744

Conversation

HarshLunagariya commented Jul 16, 2024 • edited Loading

Description

Issues Resolved

Test Scenarios Covered

Check List

coveralls commented Jul 16, 2024 • edited Loading

Pull Request Test Coverage Report for Build 10056627748

Warning: This coverage report may be inaccurate.

Details

💛 - Coveralls

forestkeeper left a comment

Choose a reason for hiding this comment

shah-nirmit Jul 18, 2024

Choose a reason for hiding this comment

Deepesh125 Jul 19, 2024

Choose a reason for hiding this comment

HarshLunagariya Jul 23, 2024

Choose a reason for hiding this comment

HarshLunagariya commented Jul 16, 2024 •

edited

Loading

coveralls commented Jul 16, 2024 •

edited

Loading