Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OSS-ONLY] Finalize BABEL_4_4_STABLE #3047

Conversation

thephantomthief
Copy link
Contributor

This commit includes the following changes:

  • Disable TDS fault injection flag and tests
  • Update DEFAULT_BRANCH to point to stable branch
  • Update workflows to point to stable branch

Signed-off-by: Sharu Goel [email protected]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

This commit includes the following changes:
- Disable TDS fault injection flag and tests
- Update DEFAULT_BRANCH to point to stable branch
- Update workflows to point to stable branch

Signed-off-by: Sharu Goel <[email protected]>
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 11478728069

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 216 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.4%) to 74.154%

Files with Coverage Reduction New Missed Lines %
contrib/babelfishpg_tds/src/backend/tds/tdsutils.c 3 73.6%
contrib/babelfishpg_tds/src/backend/fault_injection/fault_injection_tests.c 62 0.0%
contrib/babelfishpg_tds/src/backend/fault_injection/fault_injection.c 151 1.79%
Totals Coverage Status
Change from base Build 11476724720: -0.4%
Covered Lines: 44990
Relevant Lines: 60671

💛 - Coveralls

@@ -11,7 +11,7 @@ TSQL_SRC = ../babelfishpg_tsql

PG_CFLAGS += -Werror -Wfloat-conversion
PG_CFLAGS += -fstack-protector-strong
PG_CPPFLAGS += -I$(TSQL_SRC) -I$(PG_SRC) -I$(tds_top_dir) -DFAULT_INJECTOR
PG_CPPFLAGS += -I$(TSQL_SRC) -I$(PG_SRC) -I$(tds_top_dir)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not in tsql extension make file ?

@shardgupta shardgupta merged commit 2c673b7 into babelfish-for-postgresql:BABEL_4_4_STABLE Oct 23, 2024
46 checks passed
@shardgupta shardgupta deleted the sharu-dev-stable-4-4 branch October 23, 2024 13:16
Yvinayak07 pushed a commit to amazon-aurora/babelfish_extensions that referenced this pull request Nov 8, 2024
This commit includes the following changes:
- Disable TDS fault injection flag and tests
- Update DEFAULT_BRANCH to point to stable branch
- Update workflows to point to stable branch

Signed-off-by: Sharu Goel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants