Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OSS-ONLY] Update database collation related tests #3066

Conversation

ahmed-shameem
Copy link
Contributor

Description

To obtain the collation related metadata information of a table returning function we were using sp_describe_first_result_set till now. This procedure also returns the system_type_id (oid) of the datatype, which can change (but not an actual issue). As we only aim to obtain the collation related info, updated the test in such a way to obtain expected columns.

###Issues Resolved
test_db_collation
Signed-off-by: Shameem Ahmed [email protected]

Test Scenarios Covered

  • Use case based -

  • Boundary conditions -

  • Arbitrary inputs -

  • Negative test cases -

  • Minor version upgrade tests -

  • Major version upgrade tests -

  • Performance tests -

  • Tooling impact -

  • Client tests -

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Shameem Ahmed <[email protected]>
(cherry picked from commit 2e8ae24)
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 11589504975

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 74.154%

Totals Coverage Status
Change from base Build 11512703606: 0.0%
Covered Lines: 44990
Relevant Lines: 60671

💛 - Coveralls

@ahmed-shameem ahmed-shameem changed the title Update database collation related tests [OSS-ONLY] Update database collation related tests Oct 30, 2024
@shardgupta shardgupta merged commit 9603fe7 into babelfish-for-postgresql:BABEL_4_4_STABLE Oct 30, 2024
46 checks passed
@shardgupta shardgupta deleted the update-db_collation-prep-4-4-stable branch October 30, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants