Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix syntax error issue while using [primary] column name in DML/DDL statements #3132

Conversation

sumitj824
Copy link
Contributor

Description

This commit resolves the syntax error issue that occurs when using '[primary]' as a column name in DML and DDL statements.

Signed-off-by: Sumit Jaiswal [email protected]

Issues Resolved

Task: BABEL-5422
Issue: #3127

Test Scenarios Covered

  • Use case based - Yes

  • Boundary conditions - Yes

  • Arbitrary inputs - NA

  • Negative test cases - NA

  • Minor version upgrade tests - NA

  • Major version upgrade tests - NA

  • Performance tests - NA

  • Tooling impact - NA

  • Client tests - NA

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…tatements (babelfish-for-postgresql#3131)

This commit resolves the syntax error issue that occurs when using '[primary]' as a column name in DML and DDL statements.

Task: BABEL-5422
Issue: babelfish-for-postgresql#3127

Signed-off-by: Sumit Jaiswal [email protected]
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 11912859714

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 74.151%

Totals Coverage Status
Change from base Build 11818054106: 0.0%
Covered Lines: 44982
Relevant Lines: 60663

💛 - Coveralls

@shardgupta shardgupta merged commit d0aa61c into babelfish-for-postgresql:BABEL_4_4_STABLE Nov 20, 2024
46 checks passed
@shardgupta shardgupta deleted the jira-babel-5422-stable branch November 20, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants