Changing time difference for non daylight saving period in getdate test file. #3074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yashneet vinayak <[email protected]>
Signed-off-by: yashneet vinayak <[email protected]>
tanscorpio7
approved these changes
Nov 5, 2024
rohit01010
approved these changes
Nov 5, 2024
Signed-off-by: yashneet vinayak <[email protected]>
Signed-off-by: yashneet vinayak <[email protected]>
thephantomthief
approved these changes
Nov 5, 2024
shardgupta
approved these changes
Nov 5, 2024
shardgupta
merged commit a4fc9fa
into
babelfish-for-postgresql:BABEL_4_X_DEV
46 checks passed
thephantomthief
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Nov 5, 2024
…st file. (babelfish-for-postgresql#3074) As daylight saving period ends minute difference between 'UTC' and 'US/Pacific' is changed from 420 to 480. So changed the time zone from 'US/Pacific' to 'Asia/Kolkata' making it independent from daylight saving period. Task: No-JIRA Signed-off-by: yashneet vinayak <[email protected]>
Yvinayak07
added a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Nov 8, 2024
…st file. (babelfish-for-postgresql#3074) As daylight saving period ends minute difference between 'UTC' and 'US/Pacific' is changed from 420 to 480. So changed the time zone from 'US/Pacific' to 'Asia/Kolkata' making it independent from daylight saving period. Task: No-JIRA Signed-off-by: yashneet vinayak <[email protected]>
Yvinayak07
added a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Nov 8, 2024
…st file. (babelfish-for-postgresql#3074) As daylight saving period ends minute difference between 'UTC' and 'US/Pacific' is changed from 420 to 480. So changed the time zone from 'US/Pacific' to 'Asia/Kolkata' making it independent from daylight saving period. Task: No-JIRA Signed-off-by: yashneet vinayak <[email protected]>
jsudrik
pushed a commit
that referenced
this pull request
Nov 8, 2024
…st file. (#3074) (#3086) As daylight saving period ends minute difference between 'UTC' and 'US/Pacific' is changed from 420 to 480. So changed the time zone from 'US/Pacific' to 'Asia/Kolkata' making it independent from daylight saving period. Task: No-JIRA Signed-off-by: yashneet vinayak <[email protected]>
jsudrik
pushed a commit
that referenced
this pull request
Nov 8, 2024
…st file. (#3074) (#3087) As daylight saving period ends minute difference between 'UTC' and 'US/Pacific' is changed from 420 to 480. So changed the time zone from 'US/Pacific' to 'Asia/Kolkata' making it independent from daylight saving period. Issues Resolved getdate tests were failing because of this issue. Task: No-JIRA Signed-off-by: yashneet vinayak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As daylight saving period ends Minute difference between 'UTC' and 'US/Pacific' is changed from 420 to 480. So changed the time zone from 'US/Pacific' to 'Asia/Kolkata' making it independent from daylight saving period.
Issues Resolved
getdate tests were failing because of this issue.
Test Scenarios Covered
Use case based - NA
Boundary conditions - NA
Arbitrary inputs - NA
Negative test cases - NA
Minor version upgrade tests - NA
Major version upgrade tests - NA
Performance tests - NA
Tooling impact - NA
Client tests -
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.