Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note Permission: If userName does not exist in the shiro.ini file, can't be saved! #884

Closed
wants to merge 26 commits into from

Conversation

wind0727
Copy link
Contributor

@wind0727 wind0727 commented May 11, 2016

What is this PR for?

Note Permission: If userName does not exist in the shiro.ini file, can't be saved!

What type of PR is it?

Bug

Todos

  • - Task

What is the Jira issue?

no

How should this be tested?

  1. click one notebook,into notebook edit page.
  2. click Note Permission button.
  3. Owners/Readers/Writers: input any word of shrio.ini not exists
  4. Pop-up prompt: User: "" is not exists, Please Check!

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update? no
  • Is there breaking changes for older versions? no
  • Does this needs documentation? no

@wind0727 wind0727 changed the title Note Permission: if input userName is not exists of shiro.ini,cannot save! Note Permission: If userName does not exist in the shiro.ini file, can't be saved! May 11, 2016
@@ -99,6 +100,10 @@ String ownerPermissionError(Set<String> current,
"Allowed owners: " + allowed.toString() + "\n\n" +
"User belongs to: " + current.toString();
}

String userNamePermissionError(String userName) throws IOException {
return "User: " + userName + " not Exists,Please Check !";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need a separate method here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prompt input user does not exist,No common method calls

@Leemoonsoo
Copy link
Member

Thanks @wind0727 for the bug fix.

Are modifications of line 141163 and 713729 of NotebookRestApi.java part of this contribution?
If not, could you try include changes for this contribution only? Let me know if you need any help.

@wind0727
Copy link
Contributor Author

OK,I try to change it,

Failed tests:
NotebookRestApiTest.testPermissions:70 test update method:
Expected: HTTP response <200> from /api/notebook/2BJ8WCYBQ/permissions/
but: got <403> Forbidden

what‘s problem is this?

@corneadoug
Copy link
Contributor

@wind0727 The history is a bit weird.
Could you create a new branch (not based on master) and create a new PR?
This will clean the history and take care of conflicts

@corneadoug
Copy link
Contributor

@wind0727 Any plan on taking care of this PR?
I think it would need a new one, based on a special branch instead of your master.

@asfgit asfgit closed this in c38a0a0 May 9, 2018
asfgit pushed a commit that referenced this pull request May 9, 2018
close #83
close #86
close #125
close #133
close #139
close #146
close #193
close #203
close #246
close #262
close #264
close #273
close #291
close #299
close #320
close #347
close #389
close #413
close #423
close #543
close #560
close #658
close #670
close #728
close #765
close #777
close #782
close #783
close #812
close #822
close #841
close #843
close #878
close #884
close #918
close #989
close #1076
close #1135
close #1187
close #1231
close #1304
close #1316
close #1361
close #1385
close #1390
close #1414
close #1422
close #1425
close #1447
close #1458
close #1466
close #1485
close #1492
close #1495
close #1497
close #1536
close #1545
close #1561
close #1577
close #1600
close #1603
close #1678
close #1695
close #1739
close #1748
close #1765
close #1767
close #1776
close #1783
close #1799
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants