-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Note Permission: If userName does not exist in the shiro.ini file, can't be saved! #884
Conversation
@@ -99,6 +100,10 @@ String ownerPermissionError(Set<String> current, | |||
"Allowed owners: " + allowed.toString() + "\n\n" + | |||
"User belongs to: " + current.toString(); | |||
} | |||
|
|||
String userNamePermissionError(String userName) throws IOException { | |||
return "User: " + userName + " not Exists,Please Check !"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need a separate method here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prompt input user does not exist,No common method calls
Thanks @wind0727 for the bug fix. Are modifications of line 141 |
OK,I try to change it, Failed tests: what‘s problem is this? |
@wind0727 The history is a bit weird. |
@wind0727 Any plan on taking care of this PR? |
close #83 close #86 close #125 close #133 close #139 close #146 close #193 close #203 close #246 close #262 close #264 close #273 close #291 close #299 close #320 close #347 close #389 close #413 close #423 close #543 close #560 close #658 close #670 close #728 close #765 close #777 close #782 close #783 close #812 close #822 close #841 close #843 close #878 close #884 close #918 close #989 close #1076 close #1135 close #1187 close #1231 close #1304 close #1316 close #1361 close #1385 close #1390 close #1414 close #1422 close #1425 close #1447 close #1458 close #1466 close #1485 close #1492 close #1495 close #1497 close #1536 close #1545 close #1561 close #1577 close #1600 close #1603 close #1678 close #1695 close #1739 close #1748 close #1765 close #1767 close #1776 close #1783 close #1799
What is this PR for?
Note Permission: If userName does not exist in the shiro.ini file, can't be saved!
What type of PR is it?
Bug
Todos
What is the Jira issue?
no
How should this be tested?
Screenshots (if appropriate)
Questions: