Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Java 8 #658

Closed
wants to merge 1 commit into from
Closed

Switch to Java 8 #658

wants to merge 1 commit into from

Conversation

doanduyhai
Copy link
Contributor

What is this PR for?

Java 7 is now officially no longer supported by Oracle and Java 8 has been released quite a while. We should take the opportunity to switch to Java 8.

What type of PR is it?

[Improvement]

Todos

  • - Task

Is there a relevant Jira issue?

ZEPPELIN-621

How should this be tested?

  • Hava Java 8 installed locally
  • Build Zeppelin with mvn clean -Pxxxx -DskipTests
  • Create some notes with spark/angular/shell interpreter and test some basic use-case

This PR is low risk because Java 8 is backward-compatible with Java 7 source code.

Screenshots (if appropriate)

N/A

Questions:

  • Does the licenses files need update? --> No
  • Is there breaking changes for older versions? --> No
  • Does this needs documentation? --> No

@felixcheung
Copy link
Member

I think we might need this under a profile switch - there are still a lot of companies running JDK 7 - you can see the discussion similarly with Spark here: http://apache-spark-user-list.1001560.n3.nabble.com/Spark-and-Java-8-tt5443.html

What do you think?

@doanduyhai
Copy link
Contributor Author

@felixcheung I create this PR because Cassandra server version 3.0 is using Java 8. Right now, some of the features of the Cassandra interpreter cannot be tested because it requires pulling the server and so requires using Java 8 for the integration test.

In general, all the drivers that work at client side are still staying under Java 7 or even Java 6. But on the server side, it's not a problem to ask for Java 8 (because officially Java 7 is no longer supported). Since Zeppelin is a server technology, it's not that a big deal.

However it's not an urgent matter, so I'm fine if we do not switch to Java 8 right now.

Maybe we need some feedback from the community

@doanduyhai
Copy link
Contributor Author

Closing since it's not urgent matter

@doanduyhai doanduyhai closed this Jan 19, 2016
@felixcheung
Copy link
Member

right - feedback would be good. I think it's a great idea but I can't move to JDK 8 yet ;)
thanks for taking the lead on this though.

@anthonycorbacho
Copy link
Contributor

For me massive +1, this will allow us to update some ancient library.

@bzz
Copy link
Member

bzz commented Jan 23, 2016

Geode interpreter also depends on 1.8 https://issues.apache.org/jira/browse/ZEPPELIN-375

Would be nice to switch eventually too (i.e through profile at first)

@pranasblk
Copy link

+1

@thepolina
Copy link

Any news regarding upgrade to java 8?

@pmleveque
Copy link

Spark 2.2 requires Java 1.8

@felixcheung
Copy link
Member

yes it does. Zeppelin supports older versions of spark though (and other frameworks)

@mf69
Copy link

mf69 commented Sep 29, 2017

News flash...Java 7 was EOL over 2 years ago.
https://www.java.com/en/download/faq/java_7.xml

What more does it take to get Zeppelin working with Java 8?

@1ambda
Copy link
Member

1ambda commented Oct 2, 2017

and we have java 9 and Hadoop 3 increased the minimum java version from 7 to 8. Should we start to discuss using JDK 8 by default?

@felixcheung
Copy link
Member

felixcheung commented Oct 2, 2017 via email

@mf69
Copy link

mf69 commented Oct 5, 2017

@doanduyhai since it's fairly urgent now so please consider re-opening the pull request?

@doanduyhai doanduyhai reopened this Oct 5, 2017
@doanduyhai
Copy link
Contributor Author

@mf69 done, PR re-opened

@asfgit asfgit closed this in c38a0a0 May 9, 2018
asfgit pushed a commit that referenced this pull request May 9, 2018
close #83
close #86
close #125
close #133
close #139
close #146
close #193
close #203
close #246
close #262
close #264
close #273
close #291
close #299
close #320
close #347
close #389
close #413
close #423
close #543
close #560
close #658
close #670
close #728
close #765
close #777
close #782
close #783
close #812
close #822
close #841
close #843
close #878
close #884
close #918
close #989
close #1076
close #1135
close #1187
close #1231
close #1304
close #1316
close #1361
close #1385
close #1390
close #1414
close #1422
close #1425
close #1447
close #1458
close #1466
close #1485
close #1492
close #1495
close #1497
close #1536
close #1545
close #1561
close #1577
close #1600
close #1603
close #1678
close #1695
close #1739
close #1748
close #1765
close #1767
close #1776
close #1783
close #1799
@alexott
Copy link
Contributor

alexott commented Jun 17, 2018

Why it still not implemented? Spark starting with 2.2.0 works only with Java 8...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants