Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade angularJS from 1.3.x to 1.5.0 (stable) #783

Closed
wants to merge 8 commits into from

Conversation

prabhjyotsingh
Copy link
Contributor

What is this PR for?

upgrade angularJS from 1.3.x to 1.5.0 (stable)

What type of PR is it?

Improvement

Todos

  • - Upgrade in bower.json
  • - make upgrade change in app.js

Is there a relevant Jira issue?

N/A

How should this be tested?

Try grunt test on zeppelin-web

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update?
    No
  • Is there breaking changes for older versions?
    No
  • Does this needs documentation?
    No

@prabhjyotsingh prabhjyotsingh force-pushed the upgradeAngularJS branch 2 times, most recently from 98ece75 to 1f422c0 Compare March 18, 2016 11:16
@felixcheung
Copy link
Member

looks like the zeppelin page is up in the screenshot when selenium test failed:

10:37:56,531 ERROR org.apache.zeppelin.AbstractZeppelinIT:173 - Exception in ParagraphActionsIT while testCreateNewButton 
org.openqa.selenium.ElementNotVisibleException: Element is not currently visible and so may not be interacted with
Command duration or timeout: 8 milliseconds
Build info: version: '2.48.2', revision: '41bccdd10cf2c0560f637404c2d96164b67d9d67', time: '2015-10-09 13:08:06'
System info: host: 'testing-worker-linux-docker-7b2e2a82-3397-linux-9', ip: '172.17.8.24', os.name: 'Linux', os.arch: 'amd64', os.version: '3.13.0-40-generic', java.version: '1.7.0_76'
Session ID: 240c3bb6-eb48-4e3c-9917-046f70a6b4a7
Driver info: org.openqa.selenium.firefox.FirefoxDriver
Capabilities [{platform=LINUX, acceptSslCerts=true, javascriptEnabled=true, cssSelectorsEnabled=true, databaseEnabled=true, browserName=firefox, handlesAlerts=true, nativeEvents=false, webStorageEnabled=true, rotatable=false, locationContextEnabled=true, applicationCacheEnabled=true, takesScreenshot=true, version=31.0}]
    at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)

@prabhjyotsingh
Copy link
Contributor Author

Thank you @felixcheung. Yes, I noticed CI was continuously failing for this.

https://travis-ci.org/apache/incubator-zeppelin/builds/116868449
https://travis-ci.org/apache/incubator-zeppelin/builds/116864607
https://travis-ci.org/apache/incubator-zeppelin/builds/116860666
https://travis-ci.org/apache/incubator-zeppelin/builds/116834473

Hence, created a new PR #785. Tried to merge that here, and check if this works.

@prabhjyotsingh
Copy link
Contributor Author

Last build errors with

[ERROR] Failed to execute goal com.github.eirslett:frontend-maven-plugin:0.0.25:install-node-and-npm (install node and npm) on project zeppelin-web: Could not download Node.js: Got error code 522 from the server. -> [Help 1]

But, now its green.

@felixcheung
Copy link
Member

so looks like this is merged with #785 ?
let's get that PR committed first...

@prabhjyotsingh
Copy link
Contributor Author

Yes, have merged this with #785.

@prabhjyotsingh
Copy link
Contributor Author

I've merged with master, and this can now be review.

@felixcheung
Copy link
Member

looks good.
@corneadoug any issue with this angular version?

@prabhjyotsingh
Copy link
Contributor Author

Merge this?

@asfgit asfgit closed this in df39c02 Mar 26, 2016
onkarshedge pushed a commit to onkarshedge/incubator-zeppelin that referenced this pull request May 11, 2016
### What is this PR for?
upgrade angularJS from 1.3.x to 1.5.0 (stable)

### What type of PR is it?
Improvement

### Todos
* [x] - Upgrade in bower.json
* [x] - make upgrade change in app.js

### Is there a relevant Jira issue?
N/A

### How should this be tested?
Try `grunt test` on zeppelin-web

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update?
No
* Is there breaking changes for older versions?
No
* Does this needs documentation?
No

Author: Prabhjyot Singh <[email protected]>

Closes apache#783 from prabhjyotsingh/upgradeAngularJS and squashes the following commits:

f87c69b [Prabhjyot Singh] Merge remote-tracking branch 'origin/master' into upgradeAngularJS
d2e600c [Prabhjyot Singh] test empty commit for CI
d3c3340 [Prabhjyot Singh] test empty commit for CI
a5d09e5 [Prabhjyot Singh] Merge remote-tracking branch 'origin/increaseImplicitlyWait' into upgradeAngularJS
2a51a1f [Prabhjyot Singh] add waitForParagraph(1, "FINISHED"); change assertTrue to waitForParagraph(1, "FINISHED");
0249b49 [Prabhjyot Singh] replace sendkeys with javascript function
1f422c0 [Prabhjyot Singh] upgrade angularJS from 1.3.x to 1.5.0 (stable)
734a901 [Prabhjyot Singh] increase implicitlyWait for WebDriver
@prabhjyotsingh prabhjyotsingh deleted the upgradeAngularJS branch August 15, 2017 19:36
asfgit pushed a commit that referenced this pull request May 9, 2018
close #83
close #86
close #125
close #133
close #139
close #146
close #193
close #203
close #246
close #262
close #264
close #273
close #291
close #299
close #320
close #347
close #389
close #413
close #423
close #543
close #560
close #658
close #670
close #728
close #765
close #777
close #783
close #812
close #822
close #841
close #843
close #878
close #884
close #918
close #989
close #1076
close #1135
close #1187
close #1231
close #1304
close #1316
close #1361
close #1385
close #1390
close #1414
close #1422
close #1425
close #1447
close #1458
close #1466
close #1485
close #1492
close #1495
close #1497
close #1536
close #1545
close #1561
close #1577
close #1600
close #1603
close #1678
close #1695
close #1739
close #1748
close #1765
close #1767
close #1776
close #1783
close #1799
asfgit pushed a commit that referenced this pull request May 9, 2018
close #83
close #86
close #125
close #133
close #139
close #146
close #193
close #203
close #246
close #262
close #264
close #273
close #291
close #299
close #320
close #347
close #389
close #413
close #423
close #543
close #560
close #658
close #670
close #728
close #765
close #777
close #782
close #783
close #812
close #822
close #841
close #843
close #878
close #884
close #918
close #989
close #1076
close #1135
close #1187
close #1231
close #1304
close #1316
close #1361
close #1385
close #1390
close #1414
close #1422
close #1425
close #1447
close #1458
close #1466
close #1485
close #1492
close #1495
close #1497
close #1536
close #1545
close #1561
close #1577
close #1600
close #1603
close #1678
close #1695
close #1739
close #1748
close #1765
close #1767
close #1776
close #1783
close #1799
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants