-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade angularJS from 1.3.x to 1.5.0 (stable) #783
Conversation
60e0c06
to
248d7a9
Compare
98ece75
to
1f422c0
Compare
looks like the zeppelin page is up in the screenshot when selenium test failed:
|
change assertTrue to waitForParagraph(1, "FINISHED");
Thank you @felixcheung. Yes, I noticed CI was continuously failing for this.
Hence, created a new PR #785. Tried to merge that here, and check if this works. |
43b1657
to
d2e600c
Compare
Last build errors with
But, now its green. |
so looks like this is merged with #785 ? |
Yes, have merged this with #785. |
I've merged with master, and this can now be review. |
looks good. |
Merge this? |
### What is this PR for? upgrade angularJS from 1.3.x to 1.5.0 (stable) ### What type of PR is it? Improvement ### Todos * [x] - Upgrade in bower.json * [x] - make upgrade change in app.js ### Is there a relevant Jira issue? N/A ### How should this be tested? Try `grunt test` on zeppelin-web ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Prabhjyot Singh <[email protected]> Closes apache#783 from prabhjyotsingh/upgradeAngularJS and squashes the following commits: f87c69b [Prabhjyot Singh] Merge remote-tracking branch 'origin/master' into upgradeAngularJS d2e600c [Prabhjyot Singh] test empty commit for CI d3c3340 [Prabhjyot Singh] test empty commit for CI a5d09e5 [Prabhjyot Singh] Merge remote-tracking branch 'origin/increaseImplicitlyWait' into upgradeAngularJS 2a51a1f [Prabhjyot Singh] add waitForParagraph(1, "FINISHED"); change assertTrue to waitForParagraph(1, "FINISHED"); 0249b49 [Prabhjyot Singh] replace sendkeys with javascript function 1f422c0 [Prabhjyot Singh] upgrade angularJS from 1.3.x to 1.5.0 (stable) 734a901 [Prabhjyot Singh] increase implicitlyWait for WebDriver
close #83 close #86 close #125 close #133 close #139 close #146 close #193 close #203 close #246 close #262 close #264 close #273 close #291 close #299 close #320 close #347 close #389 close #413 close #423 close #543 close #560 close #658 close #670 close #728 close #765 close #777 close #783 close #812 close #822 close #841 close #843 close #878 close #884 close #918 close #989 close #1076 close #1135 close #1187 close #1231 close #1304 close #1316 close #1361 close #1385 close #1390 close #1414 close #1422 close #1425 close #1447 close #1458 close #1466 close #1485 close #1492 close #1495 close #1497 close #1536 close #1545 close #1561 close #1577 close #1600 close #1603 close #1678 close #1695 close #1739 close #1748 close #1765 close #1767 close #1776 close #1783 close #1799
close #83 close #86 close #125 close #133 close #139 close #146 close #193 close #203 close #246 close #262 close #264 close #273 close #291 close #299 close #320 close #347 close #389 close #413 close #423 close #543 close #560 close #658 close #670 close #728 close #765 close #777 close #782 close #783 close #812 close #822 close #841 close #843 close #878 close #884 close #918 close #989 close #1076 close #1135 close #1187 close #1231 close #1304 close #1316 close #1361 close #1385 close #1390 close #1414 close #1422 close #1425 close #1447 close #1458 close #1466 close #1485 close #1492 close #1495 close #1497 close #1536 close #1545 close #1561 close #1577 close #1600 close #1603 close #1678 close #1695 close #1739 close #1748 close #1765 close #1767 close #1776 close #1783 close #1799
What is this PR for?
upgrade angularJS from 1.3.x to 1.5.0 (stable)
What type of PR is it?
Improvement
Todos
Is there a relevant Jira issue?
N/A
How should this be tested?
Try
grunt test
on zeppelin-webScreenshots (if appropriate)
Questions:
No
No
No