[ZEPPELIN-1706] Make spark Ui accesible in various interpreter modes #1678
Conversation
karuppayya
force-pushed
the
ZEPPELIN-1706
branch
2 times, most recently
from
a94fd5d to
6ec58e8
Compare
|
@Leemoonsoo @zjffdu Ready for review |
| @@ -243,17 +244,26 @@ public Response addRepository(String message) { | |||
| /** | |||
| * get the metainfo property value | |||
| */ | |||
| @GET | |||
| @POST | |||
There was a problem hiding this comment.
Why this is changed to POST ?
There was a problem hiding this comment.
I wanted to send more amount of parameter data , hence started using POST
https://github.com/apache/zeppelin/pull/1678/files/6ec58e8ebf2493e5f417d5ee3c352ab3c4c793bd#diff-79927cd87b606e2efc3267cf436aa704R643
Also read this in one of the posts.
an important consideration when using GET for AJAX requests is that some browsers - IE in particular - will cache the results of a GET request
Not very sure if its applicable.
One another reason is to keep the url cleaner :)
There was a problem hiding this comment.
POST is for request that would make state changes on server side, GET is just for read-only operation. IIUC this api didn't change anything in server side, then we should use GET.
karuppayya
force-pushed
the
ZEPPELIN-1706
branch
from
1bc76fa to
9692534
Compare
…ckages" This reverts commit abe03a8.
Signed-off-by: karuppayya <[email protected]>
…, npm packages"" This reverts commit f755fb4.
Signed-off-by: karuppayya <[email protected]>
Signed-off-by: karuppayya <[email protected]>
Signed-off-by: karuppayya <[email protected]>
Signed-off-by: karuppayya <[email protected]>
Signed-off-by: karuppayya <[email protected]>
karuppayya
force-pushed
the
ZEPPELIN-1706
branch
from
2d48306 to
3f4cedc
Compare
|
@zjffdu I have addressed the feedbacks . |
|
@Leemoonsoo @zjffdu can u please take a look.and let me know how it looks |
| @@ -108,8 +108,8 @@ | |||
| <goal>install-node-and-npm</goal> | |||
| </goals> | |||
| <configuration> | |||
| <nodeVersion>${node.version}</nodeVersion> | |||
| <npmVersion>${npm.version}</npmVersion> | |||
| <nodeVersion>v6.9.1</nodeVersion> | |||
There was a problem hiding this comment.
this change makes no sense in the scope of this PR
|
ping @karuppayya |
close #83 close #86 close #125 close #133 close #139 close #146 close #193 close #203 close #246 close #262 close #264 close #273 close #291 close #299 close #320 close #347 close #389 close #413 close #423 close #543 close #560 close #658 close #670 close #728 close #765 close #777 close #782 close #783 close #812 close #822 close #841 close #843 close #878 close #884 close #918 close #989 close #1076 close #1135 close #1187 close #1231 close #1304 close #1316 close #1361 close #1385 close #1390 close #1414 close #1422 close #1425 close #1447 close #1458 close #1466 close #1485 close #1492 close #1495 close #1497 close #1536 close #1545 close #1561 close #1577 close #1600 close #1603 close #1678 close #1695 close #1739 close #1748 close #1765 close #1767 close #1776 close #1783 close #1799
What is this PR for?
Spark UI should be accessible in various other modes(user, note) and honour the properties of the corresponding mode.
Example: In per user mode isolated mode, each logged in user should be taken to his/her respective spark UI
In per note isolated mode, each notebook will have its own application and the user should be taken the respective spark application UI
All the interpreter modes are handled with this PR
What type of PR is it?
Bug fix
What is the Jira issue?
ZEPPELIN-1706
How should this be tested?
Set various interpreter modes for the interpreter setting and test if the spark Application UI is accessible appropriately
Screenshots (if appropriate)
The screen capture shows per note isolated mode. But the PR handles all interpreter modes
Questions: