ZEPPELIN-1817 - Added documentation to Zeppelin's shiro.ini to provide help users configure security #1767
Conversation
|
LGTM! |
conf/shiro.ini.template
Outdated
| @@ -14,6 +14,34 @@ | |||
| # See the License for the specific language governing permissions and | |||
| # limitations under the License. | |||
| # | |||
| # Zeppelin uses Shiro to configure Security. The first step of security is Authentication. | |||
| # To enable authentication, you need to configure authc as the authentication method in | |||
| # the URL section of shiro.ini. Make sure the shiro.ini has "/** = authc" line uncommented | |||
There was a problem hiding this comment.
It's just my opinion, but how about adding this info in here?
"You can activate Shiro by copying shiro.ini.template to shiro.ini." :)
|
@vinayshukla Looks good 👍 |
|
Thanks @vinayshukla for the contribution. We have a document about configuring shiro authentication on website. What do you think keeping information in the single document(website), instead of keeping two different document for the single feature? |
|
Great improvement, thank you @vinayshukla ! |
Addressing review comments
Enhanced overview section to address comments from apache#1767
Addressed review comments.
|
@Leemoonsoo The CI failure is unrelated, the 2 files changed are template and markdown. Is there a way to re-trigger the CI? |
|
@vinayshukla I think what @Leemoonsoo suggested was having only one documentation about this info. What do you think? |
|
when I set to property zeppelin.anonymous.allowed to true in conf/zeppelin-site.xml and set cfg in the shiro like this: I also need login using username/password |
|
@qinchaofeng If you want to turn off shiro(login as |
|
@AhyoungRyu thinks, and the question is I set shiro.ini like this:
|
close #83 close #86 close #125 close #133 close #139 close #146 close #193 close #203 close #246 close #262 close #264 close #273 close #291 close #299 close #320 close #347 close #389 close #413 close #423 close #543 close #560 close #658 close #670 close #728 close #765 close #777 close #782 close #783 close #812 close #822 close #841 close #843 close #878 close #884 close #918 close #989 close #1076 close #1135 close #1187 close #1231 close #1304 close #1316 close #1361 close #1385 close #1390 close #1414 close #1422 close #1425 close #1447 close #1458 close #1466 close #1485 close #1492 close #1495 close #1497 close #1536 close #1545 close #1561 close #1577 close #1600 close #1603 close #1678 close #1695 close #1739 close #1748 close #1765 close #1767 close #1776 close #1783 close #1799
What is this PR for?
Add documentation to Zeppelin's shiro.ini to provide help users configure security
The added documentation walks through different security stages
What type of PR is it?
Documentation
Todos
What is the Jira issue?
How should this be tested?
This pull request add only documentation, to see new doc, see shiro.ini.template
Questions:
N
N
N