[WIP] ZEPPELIN-1571. Support pig udf interpreter #1545
Conversation
|
@felixcheung @AhyoungRyu Please help review |
| </systemPropertyVariables> | ||
| </configuration> | ||
| </plugin> | ||
|
|
There was a problem hiding this comment.
This is for test in PigUDFInterpreterTest
|
|
||
| package org.apache.zeppelin.pig; | ||
|
|
||
| import com.thoughtworks.qdox.JavaProjectBuilder; |
There was a problem hiding this comment.
whats the license of this qdox library?
There was a problem hiding this comment.
It is apache licence 2. https://mvnrepository.com/artifact/com.thoughtworks.qdox/qdox
There was a problem hiding this comment.
we need to add that to LICENSE file?
|
@minahlee The syntax highlight for java doesn't work, could you help to check what's I missing here ? Thanks |
|
js file for java syntax highlight( |
|
Thanks @minahlee It works now. |
| LOGGER.debug("pig udf jar is created under " + tmpJarFile.getAbsolutePath()); | ||
| return tmpJarFile; | ||
| } catch (IOException e) { | ||
| throw e; |
|
2 comments, LGTM otherwise. |
|
@zjffdu What's the status of this pull request ? Can we expect it will be merged soon ? Thank you ! |
|
@zjffdu Sadly there are some conflicts now. Could you resolve them? |
zjffdu
changed the title
|
@AhyoungRyu @felixcheung I changed this PR to WIP. As there's still one issue I need to fix. The issue is that if user change the udf, the class can not been reloading unless restarting the interpreter. I need to fix this classloading issue in pig side first, then I will continue this PR. |
close #83 close #86 close #125 close #133 close #139 close #146 close #193 close #203 close #246 close #262 close #264 close #273 close #291 close #299 close #320 close #347 close #389 close #413 close #423 close #543 close #560 close #658 close #670 close #728 close #765 close #777 close #782 close #783 close #812 close #822 close #841 close #843 close #878 close #884 close #918 close #989 close #1076 close #1135 close #1187 close #1231 close #1304 close #1316 close #1361 close #1385 close #1390 close #1414 close #1422 close #1425 close #1447 close #1458 close #1466 close #1485 close #1492 close #1495 close #1497 close #1536 close #1545 close #1561 close #1577 close #1600 close #1603 close #1678 close #1695 close #1739 close #1748 close #1765 close #1767 close #1776 close #1783 close #1799
What is this PR for?
Support a new interpreter
%pig.udffor Pig Interpreter group. User can write pig udf in this interpreter, and will compile/build this udf to jar which would be registered in pig automatically.What type of PR is it?
[Feature]
Todos
What is the Jira issue?
How should this be tested?
Unit test is added
Screenshots (if appropriate)
Questions: