refactor: move superset-ui/dimension to core #732

ktmud · 2020-08-11T20:26:32Z

🏠 Internal

Keep merging more superset-ui packages.

vercel · 2020-08-11T20:26:37Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/32dq94ir8
✅ Preview: https://superset-ui-git-fork-ktmud-monopackage-move-dimension.superset.vercel.app

codecov · 2020-08-20T22:22:48Z

Codecov Report

Merging #732 into monopackage will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           monopackage     #732   +/-   ##
============================================
  Coverage        24.29%   24.29%           
============================================
  Files              337      337           
  Lines             7697     7697           
  Branches           955      955           
============================================
  Hits              1870     1870           
  Misses            5753     5753           
  Partials            74       74

Impacted Files	Coverage Δ
...es/superset-ui-chart/src/components/SuperChart.tsx	`100.00% <ø> (ø)`
...perset-ui-core/src/dimension/computeMaxFontSize.ts	`100.00% <ø> (ø)`
...ui-core/src/dimension/getMultipleTextDimensions.ts	`100.00% <ø> (ø)`
...superset-ui-core/src/dimension/getTextDimension.ts	`100.00% <ø> (ø)`
...ages/superset-ui-core/src/dimension/mergeMargin.ts	`100.00% <ø> (ø)`
...ages/superset-ui-core/src/dimension/parseLength.ts	`100.00% <ø> (ø)`
.../superset-ui-core/src/dimension/svg/LazyFactory.ts	`100.00% <ø> (ø)`
...es/superset-ui-core/src/dimension/svg/constants.ts	`100.00% <ø> (ø)`
...t-ui-core/src/dimension/svg/createHiddenSvgNode.ts	`100.00% <ø> (ø)`
...perset-ui-core/src/dimension/svg/createTextNode.ts	`100.00% <ø> (ø)`
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdb96fb...d993aaf. Read the comment docs.

ktmud · 2020-08-20T22:24:56Z

plugins/preset-chart-xy/tsconfig.json

@@ -29,9 +29,6 @@
    },
    {
      "path": "../../packages/superset-ui-core"
-    },
-    {
-      "path": "../../packages/superset-ui-dimension"
    }
  ]
 }


This file is autogenerated by nimbus so I wouldn't worry much about the missing EOF.

ktmud · 2020-08-20T22:25:56Z

scripts/tsc.sh

+
+if [ ! "$tscExitCode" ]; then
+  echo "compiled in ${duration}"
+fi


Needed to give beautiful feedback like this:

1. move translation, connection, query to core (#729) 2. update encodable to remove formatter inter-dependency (#744) 3. move number-format and time-format to core (#730) 4: move superset-ui/dimension to core (#732)

1. move translation, connection, query to core (#729) 2. update encodable to remove formatter inter-dependency (#744) 3. move number-format and time-format to core (#730) 4: move superset-ui/dimension to core (#732) 5: move superset-ui/color to core (#755)

1. move translation, connection, query to core (#729) 2. update encodable to remove formatter inter-dependency (#744) 3. move number-format and time-format to core (#730) 4. move superset-ui/dimension to core (#732) 5. move superset-ui/color to core (#755) 6. move superset-ui/style to core (#756) 7. move superset-ui/validator to core (#757)

1. move translation, connection, query to core (#729) 2. update encodable to remove formatter inter-dependency (#744) 3. move number-format and time-format to core (#730) 4. move superset-ui/dimension to core (#732) 5. move superset-ui/color to core (#755) 6. move superset-ui/style to core (#756) 7. move superset-ui/validator to core (#757) 8: move superset-ui/chart-composition to core (#759)

1. move translation, connection, query to core (#729) 2. update encodable to remove formatter inter-dependency (#744) 3. move number-format and time-format to core (#730) 4. move superset-ui/dimension to core (#732) 5. move superset-ui/color to core (#755) 6. move superset-ui/style to core (#756) 7. move superset-ui/validator to core (#757) 8: move superset-ui/chart-composition to core (#759) 9: move superset-ui/chart to core (#760)

1. move translation, connection, query to core (#729) 2. update encodable to remove formatter inter-dependency (#744) 3. move number-format and time-format to core (#730) 4. move superset-ui/dimension to core (#732) 5. move superset-ui/color to core (#755) 6. move superset-ui/style to core (#756) 7. move superset-ui/validator to core (#757) 8. move superset-ui/chart-composition to core (#759) 9. move superset-ui/chart to core (#760)

vercel bot had a problem deploying to Preview August 11, 2020 20:26 Failure

ktmud force-pushed the monopackage-move-dimension branch from f8143a8 to 87fec32 Compare August 11, 2020 23:28

vercel bot had a problem deploying to Preview August 11, 2020 23:28 Failure

pull-request-size bot added the size/XXL label Aug 11, 2020

ktmud force-pushed the monopackage-move-formatter branch from a07f5b7 to 0332c35 Compare August 11, 2020 23:28

ktmud force-pushed the monopackage-move-formatter branch from 0332c35 to 002d456 Compare August 20, 2020 18:21

ktmud force-pushed the monopackage-move-dimension branch from 87fec32 to cd5d80a Compare August 20, 2020 18:25

vercel bot deployed to Preview August 20, 2020 18:25 View deployment

ktmud changed the base branch from monopackage-move-formatter to monopackage August 20, 2020 18:37

ktmud force-pushed the monopackage-move-dimension branch from cd5d80a to ef2c227 Compare August 20, 2020 19:45

vercel bot deployed to Preview August 20, 2020 19:45 View deployment

vercel bot deployed to Preview August 20, 2020 20:14 View deployment

ktmud force-pushed the monopackage-move-dimension branch from d29c967 to 696570c Compare August 20, 2020 22:13

vercel bot deployed to Preview August 20, 2020 22:13 View deployment

ktmud marked this pull request as ready for review August 20, 2020 22:24

ktmud requested a review from a team as a code owner August 20, 2020 22:24

ktmud commented Aug 20, 2020

View reviewed changes

ktmud commented Aug 25, 2020

View reviewed changes

kristw approved these changes Aug 25, 2020

View reviewed changes

ktmud force-pushed the monopackage branch from de95e68 to 947554e Compare August 26, 2020 01:02

ktmud force-pushed the monopackage-move-dimension branch from 696570c to 7647d3b Compare August 26, 2020 01:06

vercel bot had a problem deploying to Preview August 26, 2020 01:06 Failure

ktmud force-pushed the monopackage branch from 947554e to 07374e8 Compare August 26, 2020 01:07

ktmud force-pushed the monopackage-move-dimension branch from 7647d3b to a3b510d Compare August 26, 2020 01:19

vercel bot had a problem deploying to Preview August 26, 2020 01:19 Failure

ktmud force-pushed the monopackage branch from 07374e8 to f5bdaf1 Compare August 26, 2020 01:22

ktmud force-pushed the monopackage-move-dimension branch from a3b510d to 01824f2 Compare August 26, 2020 01:24

vercel bot deployed to Preview August 26, 2020 01:24 View deployment

ktmud force-pushed the monopackage branch from f5bdaf1 to fdb96fb Compare August 26, 2020 03:40

refactor: move superset-ui/dimension to core

d993aaf

ktmud force-pushed the monopackage-move-dimension branch from 01824f2 to d993aaf Compare August 26, 2020 03:43

vercel bot deployed to Preview August 26, 2020 03:43 View deployment

ktmud merged commit 4f25e7c into apache-superset:monopackage Aug 26, 2020

ktmud mentioned this pull request Aug 26, 2020

refactor: move superset-ui/color to core #755

Merged

ktmud added a commit that referenced this pull request Aug 26, 2020

refactor: move superset-ui/dimension to core (#732)

d9cce6c

This was referenced Aug 26, 2020

refactor: move superset-ui/style to core #756

Merged

refactor: move superset-ui/validator to core #757

Merged

This was referenced Aug 27, 2020

refactor: move superset-ui/chart-composition to core #759

Merged

refactor: move chart to core #760

Merged

ktmud mentioned this pull request Sep 3, 2020

refactor: merge core superset-ui packages #768

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: move superset-ui/dimension to core #732

refactor: move superset-ui/dimension to core #732

ktmud commented Aug 11, 2020 •

edited

Loading

vercel bot commented Aug 11, 2020 •

edited

Loading

codecov bot commented Aug 20, 2020 •

edited

Loading

ktmud Aug 20, 2020

ktmud Aug 20, 2020

rusackas Aug 25, 2020

refactor: move superset-ui/dimension to core #732

refactor: move superset-ui/dimension to core #732

Conversation

ktmud commented Aug 11, 2020 • edited Loading

vercel bot commented Aug 11, 2020 • edited Loading

codecov bot commented Aug 20, 2020 • edited Loading

Codecov Report

ktmud Aug 20, 2020

Choose a reason for hiding this comment

ktmud Aug 20, 2020

Choose a reason for hiding this comment

rusackas Aug 25, 2020

Choose a reason for hiding this comment

ktmud commented Aug 11, 2020 •

edited

Loading

vercel bot commented Aug 11, 2020 •

edited

Loading

codecov bot commented Aug 20, 2020 •

edited

Loading