This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
refactor: move superset-ui/validator to core #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/superset/superset-ui/evsjg9spl |
kristw
approved these changes
Aug 26, 2020
ktmud
force-pushed
the
monopackage-move-validator
branch
from
ea79a6a
to
4dc480c
Compare
espressoroaster
approved these changes
Aug 26, 2020
ktmud
force-pushed
the
monopackage-move-validator
branch
from
4dc480c
to
691ddab
Compare
Codecov Report
@@ Coverage Diff @@
## monopackage-move-style #757 +/- ##
=======================================================
Coverage 24.29% 24.30%
=======================================================
Files 337 338 +1
Lines 7697 7698 +1
Branches 956 956
=======================================================
+ Hits 1870 1871 +1
Misses 5753 5753
Partials 74 74
Continue to review full report at Codecov.
|
ktmud
added a commit
that referenced
this pull request
Aug 26, 2020
1. move translation, connection, query to core (#729) 2. update encodable to remove formatter inter-dependency (#744) 3. move number-format and time-format to core (#730) 4. move superset-ui/dimension to core (#732) 5. move superset-ui/color to core (#755) 6. move superset-ui/style to core (#756) 7. move superset-ui/validator to core (#757)
ktmud
added a commit
that referenced
this pull request
Aug 26, 2020
1. move translation, connection, query to core (#729) 2. update encodable to remove formatter inter-dependency (#744) 3. move number-format and time-format to core (#730) 4. move superset-ui/dimension to core (#732) 5. move superset-ui/color to core (#755) 6. move superset-ui/style to core (#756) 7. move superset-ui/validator to core (#757)
This was referenced Aug 27, 2020
ktmud
added a commit
that referenced
this pull request
Sep 2, 2020
1. move translation, connection, query to core (#729) 2. update encodable to remove formatter inter-dependency (#744) 3. move number-format and time-format to core (#730) 4. move superset-ui/dimension to core (#732) 5. move superset-ui/color to core (#755) 6. move superset-ui/style to core (#756) 7. move superset-ui/validator to core (#757) 8: move superset-ui/chart-composition to core (#759)
ktmud
added a commit
that referenced
this pull request
Sep 2, 2020
1. move translation, connection, query to core (#729) 2. update encodable to remove formatter inter-dependency (#744) 3. move number-format and time-format to core (#730) 4. move superset-ui/dimension to core (#732) 5. move superset-ui/color to core (#755) 6. move superset-ui/style to core (#756) 7. move superset-ui/validator to core (#757) 8: move superset-ui/chart-composition to core (#759)
ktmud
added a commit
that referenced
this pull request
Sep 3, 2020
1. move translation, connection, query to core (#729) 2. update encodable to remove formatter inter-dependency (#744) 3. move number-format and time-format to core (#730) 4. move superset-ui/dimension to core (#732) 5. move superset-ui/color to core (#755) 6. move superset-ui/style to core (#756) 7. move superset-ui/validator to core (#757) 8: move superset-ui/chart-composition to core (#759) 9: move superset-ui/chart to core (#760)
4 tasks
ktmud
added a commit
that referenced
this pull request
Sep 3, 2020
1. move translation, connection, query to core (#729) 2. update encodable to remove formatter inter-dependency (#744) 3. move number-format and time-format to core (#730) 4. move superset-ui/dimension to core (#732) 5. move superset-ui/color to core (#755) 6. move superset-ui/style to core (#756) 7. move superset-ui/validator to core (#757) 8. move superset-ui/chart-composition to core (#759) 9. move superset-ui/chart to core (#760)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏠 Internal
Related: #728 #729 #730 #732 #755 #756