This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
refactor: merge core superset-ui packages #768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. move translation, connection, query to core (#729) 2. update encodable to remove formatter inter-dependency (#744) 3. move number-format and time-format to core (#730) 4. move superset-ui/dimension to core (#732) 5. move superset-ui/color to core (#755) 6. move superset-ui/style to core (#756) 7. move superset-ui/validator to core (#757) 8: move superset-ui/chart-composition to core (#759) 9: move superset-ui/chart to core (#760)
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/superset/superset-ui/qfkiy8v0b |
Codecov Report
@@ Coverage Diff @@
## master #768 +/- ##
==========================================
- Coverage 24.92% 24.90% -0.03%
==========================================
Files 348 353 +5
Lines 7799 7839 +40
Branches 985 1003 +18
==========================================
+ Hits 1944 1952 +8
- Misses 5751 5785 +34
+ Partials 104 102 -2
Continue to review full report at Codecov.
|
This was referenced Sep 4, 2020
6 tasks
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A colossal of moving files around to merge all core superset-ui packages into one monopackage
@superset-ui/core. This removes the needs to maintain correct inter-package dependencies and will enable us to iterate on Superset's charting foundation faster.Everything from the previous packages are exported at root. For most cases, the implication for end users is to simply replace their
import .. from '@superset-ui/xxx'toimport .. from '@superset-ui/core'. More refactoring may be planned to make some of the exports less ambiguous.The work was done in a feature branch. This PR merges the feature branch to
master. Here is a list of all related PRs:All packages are merged except
@superset-ui/chart-controlsbecause if we move it to core and export it from there, it will import the i18n functiont(...)before translations are initialized (currently users have toimport { configure } from '@superset-ui/core'to setup the language pack.Migration plan:
incubator-superset💔 Breaking Changes
🏆 Enhancements
🏠 Internal