build: move number-format and time-format to core

[ktmud]

🏠 Internal

Follow up for #729 , merging more packages to @superset-ui/core. This time the d3 formatters.

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/r4o2nrml6
✅ Preview: https://superset-ui-git-fork-ktmud-monopackage-move-formatter.superset.vercel.app

[ktmud]

@kristw Tests are failing because encodable depends on an older version of @superset-ui/number-format. What do you think is a good way to reduce such inter-dependencies?

[kristw]

@kristw Tests are failing because encodable depends on an older version of @superset-ui/number-format. What do you think is a good way to reduce such inter-dependencies?

I am working to decouple encodable from superset-ui. Should take a few more days.

[kristw]

Wonder if there is an easy way to disable certain plugin building / testing / publishing temporarily to unblock you.

[ktmud]

Wonder if there is an easy way to disable certain plugin building / testing / publishing temporarily to unblock you.

We can move the packge to temporary-plugins/? The only block package is presets-chart-xy, which we only use for Boxplot in Superset.

[kristw]

Wonder if there is an easy way to disable certain plugin building / testing / publishing temporarily to unblock you.

We can move the packge to temporary-plugins/? The only block package is presets-chart-xy, which we only use for Boxplot in Superset.

sgtm

[codecov]

Codecov Report

Merging #730 into monopackage will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##           monopackage     #730   +/-   ##
============================================
  Coverage        24.21%   24.21%           
============================================
  Files              343      343           
  Lines             7682     7682           
  Branches           947      947           
============================================
  Hits              1860     1860           
  Misses            5749     5749           
  Partials            73       73           

Impacted Files	Coverage Δ
...es/superset-ui-chart/src/components/SuperChart.tsx	100.00% <ø> (ø)
...-ui-chart/src/components/createLoadableRenderer.ts	100.00% <ø> (ø)
...uperset-ui-core/src/number-format/NumberFormats.ts	100.00% <ø> (ø)
...erset-ui-core/src/number-format/NumberFormatter.ts	100.00% <ø> (ø)
...-core/src/number-format/NumberFormatterRegistry.ts	100.00% <ø> (ø)
...number-format/factories/createD3NumberFormatter.ts	100.00% <ø> (ø)
...number-format/factories/createDurationFormatter.ts	100.00% <ø> (ø)
...-format/factories/createSiAtMostNDigitFormatter.ts	100.00% <ø> (ø)
...ber-format/factories/createSmartNumberFormatter.ts	100.00% <ø> (ø)
...es/superset-ui-core/src/time-format/TimeFormats.ts	100.00% <ø> (ø)
... and 42 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca4aaab...002d456. Read the comment docs.

[ktmud]

There are a couple of other plugins also use encodable. It's too much work to move them (and their storybook examples) back and forth. I'll just leave this PR here and work on merging other packages instead.