Add feedbacks for tsc

apache-superset · Aug 26, 2020 · a3b510d · a3b510d
1 parent dd96738
commit a3b510d
Show file tree

Hide file tree

Showing 11 changed files with 25 additions and 14 deletions.
diff --git a/package.json b/package.json
@@ -25,6 +25,7 @@
     "test": "yarn jest",
     "test:watch": "yarn lint:fix && yarn jest --watch",
     "type": "yarn build --no-babel",
+    "type:nimbus": "nimbus typescript --build --reference-workspaces",
     "prepare-release": "git checkout master && git pull --rebase origin master && yarn install && yarn test",
     "prerelease": "yarn build",
     "release": "yarn prepare-release && lerna publish && yarn postrelease",

diff --git a/packages/superset-ui-core/test/dimension/computeMaxFontSize.test.ts b/packages/superset-ui-core/test/dimension/computeMaxFontSize.test.ts
@@ -1,4 +1,4 @@
-import { computeMaxFontSize } from '../src';
+import { computeMaxFontSize } from '@superset-ui/core/src';
 import { addDummyFill, removeDummyFill, SAMPLE_TEXT } from './getBBoxDummyFill';
 
 describe('computeMaxFontSize(input)', () => {
@@ -7,11 +7,11 @@ describe('computeMaxFontSize(input)', () => {
     afterEach(removeDummyFill);
 
     it('requires either idealFontSize or maxHeight', () => {
-      expect(() =>
+      expect(() => {
         computeMaxFontSize({
           text: SAMPLE_TEXT[0],
-        }),
-      ).toThrow();
+        });
+      }).toThrow();
     });
     it('computes maximum font size for given maxWidth and maxHeight', () => {
       expect(

diff --git a/packages/superset-ui-core/test/dimension/getMultipleTextDimensions.test.ts b/packages/superset-ui-core/test/dimension/getMultipleTextDimensions.test.ts
@@ -1,5 +1,4 @@
-import { promiseTimeout } from '@superset-ui/core';
-import { getMultipleTextDimensions } from '../src';
+import { getMultipleTextDimensions, promiseTimeout } from '@superset-ui/core/src';
 import { addDummyFill, removeDummyFill, SAMPLE_TEXT } from './getBBoxDummyFill';
 
 describe('getMultipleTextDimension(input)', () => {

diff --git a/packages/superset-ui-core/test/dimension/mergeMargin.test.ts b/packages/superset-ui-core/test/dimension/mergeMargin.test.ts
@@ -1,4 +1,4 @@
-import { mergeMargin } from '../src';
+import { mergeMargin } from '@superset-ui/core/src';
 
 describe('mergeMargin(margin1, margin2, mode?)', () => {
   it('combines two given margin', () => {

diff --git a/packages/superset-ui-core/test/dimension/parseLength.test.ts b/packages/superset-ui-core/test/dimension/parseLength.test.ts
@@ -1,4 +1,4 @@
-import parseLength from '../src/parseLength';
+import { parseLength } from '@superset-ui/core/src';
 
 describe('parseLength(input)', () => {
   it('handles string "auto"', () => {

diff --git a/packages/superset-ui-core/test/dimension/svg/LazyFactory.test.ts b/packages/superset-ui-core/test/dimension/svg/LazyFactory.test.ts
@@ -1,4 +1,4 @@
-import LazyFactory from '../../src/svg/LazyFactory';
+import LazyFactory from '@superset-ui/core/src/dimension/svg/LazyFactory';
 
 describe('LazyFactory', () => {
   describe('createInContainer()', () => {

diff --git a/packages/superset-ui-core/test/dimension/svg/getBBoxCeil.test.ts b/packages/superset-ui-core/test/dimension/svg/getBBoxCeil.test.ts
@@ -1,5 +1,5 @@
-import getBBoxCeil from '../../src/svg/getBBoxCeil';
-import createTextNode from '../../src/svg/createTextNode';
+import getBBoxCeil from '@superset-ui/core/src/dimension/svg/getBBoxCeil';
+import createTextNode from '@superset-ui/core/src/dimension/svg/createTextNode';
 
 describe('getBBoxCeil(node, defaultDimension)', () => {
   describe('returns default dimension if getBBox() is not available', () => {

diff --git a/packages/superset-ui-core/test/dimension/svg/updateTextNode.test.ts b/packages/superset-ui-core/test/dimension/svg/updateTextNode.test.ts
@@ -1,5 +1,5 @@
-import updateTextNode from '../../src/svg/updateTextNode';
-import createTextNode from '../../src/svg/createTextNode';
+import updateTextNode from '@superset-ui/core/src/dimension/svg/updateTextNode';
+import createTextNode from '@superset-ui/core/src/dimension/svg/createTextNode';
 
 describe('updateTextNode(node, options)', () => {
   it('handles empty options', () => {

diff --git a/plugins/plugin-chart-choropleth-map/tsconfig.json b/plugins/plugin-chart-choropleth-map/tsconfig.json
@@ -26,6 +26,9 @@
     },
     {
       "path": "../../packages/superset-ui-style"
+    },
+    {
+      "path": "../../packages/superset-ui-color"
     }
   ]
 }
diff --git a/scripts/build.js b/scripts/build.js
@@ -103,5 +103,5 @@ if (shouldRunTyping) {
   // only run tsc for packages with ts files
   scope = getPackages(glob, true);
   run(`lerna exec --stream --concurrency 3 --scope ${scope} \
-       -- tsc --build`);
+       -- ../../scripts/tsc.sh --build`);
 }
diff --git a/scripts/tsc.sh b/scripts/tsc.sh
@@ -0,0 +1,8 @@
+#!/bin/bash
+startTime=$(node -e 'console.log(Date.now())')
+tscExitCode=$(tsc "$@")
+duration=$(node -e "console.log('%ss', (Date.now() - $startTime) / 1000)")
+
+if [ ! "$tscExitCode" ]; then
+  echo "compiled in ${duration}"
+fi
-Original file line number
+Diff line change
@@ Expand Up / @@ -26,6 +26,9 @@ @@
         },
         {
           "path": "../../packages/superset-ui-style"
+        },
+        {
+          "path": "../../packages/superset-ui-color"
         }
       ]
     }