Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

Commit

Permalink
Add feedbacks for tsc
Browse files Browse the repository at this point in the history
  • Loading branch information
ktmud committed Aug 20, 2020
1 parent ef2c227 commit d29c967
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 1 deletion.
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
"test": "yarn jest",
"test:watch": "yarn lint:fix && yarn jest --watch",
"type": "yarn build --no-babel",
"type:nimbus": "nimbus typescript --build --reference-workspaces",
"prepare-release": "git checkout master && git pull --rebase origin master && yarn install && yarn test",
"prerelease": "yarn build",
"release": "yarn prepare-release && lerna publish && yarn postrelease",
Expand Down
3 changes: 3 additions & 0 deletions plugins/plugin-chart-choropleth-map/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@
},
{
"path": "../../packages/superset-ui-style"
},
{
"path": "../../packages/superset-ui-color"
}
]
}
2 changes: 1 addition & 1 deletion scripts/build.js
Original file line number Diff line number Diff line change
Expand Up @@ -103,5 +103,5 @@ if (shouldRunTyping) {
// only run tsc for packages with ts files
scope = getPackages(glob, true);
run(`lerna exec --stream --concurrency 3 --scope ${scope} \
-- tsc --build`);
-- ../../scripts/tsc.sh --build`);
}
8 changes: 8 additions & 0 deletions scripts/tsc.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
#!/bin/bash
startTime=$(node -e 'console.log(Date.now())')
tscExitCode=$(tsc "$@")
duration=$(node -e "console.log('%ss', (Date.now() - $startTime) / 1000)")

if [ ! "$tscExitCode" ]; then
echo "compiled in ${duration}"
fi

0 comments on commit d29c967

Please sign in to comment.