Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to latest tokio #2200

Closed
2 of 10 tasks
dconnolly opened this issue May 25, 2021 · 0 comments · Fixed by #2994
Closed
2 of 10 tasks

Upgrade to latest tokio #2200

dconnolly opened this issue May 25, 2021 · 0 comments · Fixed by #2994
Assignees
Labels
A-dependencies Area: Dependency file updates A-network Area: Network protocol updates or fixes A-rust Area: Updates to Rust code

Comments

@dconnolly
Copy link
Contributor

dconnolly commented May 25, 2021

Scope

This ticket is only for upgrading tokio, and any required Zebra changes.

The upgrade PR must not include any optional refactors or new tokio features.
This helps reduce the risk of bugs during the upgrade.

Motivation

Zebra is a major version behind the latest tokio.

Stable tokio may help us keep the network stack and async constructions more maintainable.

Suggested Solution

  1. Upgrade all zebra crates to use tokio 1.+, and update all APIs, types, etc accordingly.
  2. We might need to remove some git dependencies to do these updates, see Remove git dependencies on Hyper, Metrics, Tower #1086.
  3. Remove the exceptions for these crates in deny.toml.

Alternatives

Don't upgrade, stay on 0.3.* tokio

PRs and Reviewers

@dconnolly dconnolly added A-dependencies Area: Dependency file updates A-rust Area: Updates to Rust code P-Medium A-network Area: Network protocol updates or fixes labels May 25, 2021
@mpguerra mpguerra added the S-needs-triage Status: A bug report needs triage label May 26, 2021
@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Jun 14, 2021
@mpguerra mpguerra added this to the 2021 Sprint 21 milestone Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dependencies Area: Dependency file updates A-network Area: Network protocol updates or fixes A-rust Area: Updates to Rust code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants