Use tokio-stream crate to replace usages of Tokio types that were Streams
#2922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
oxarbitrage
reviewed
Oct 30, 2021
There was a problem hiding this comment.
I think this looks fine and i can approve, however is hard to do so while depending on others pieces. We need to at least make a reference to the PR that will fix the build errors.
#2933 is merged and it fixed some of the errors but there are more. If they can be fixed here we can maybe consider this as a standalone pull request.
teor2345
reviewed
Nov 1, 2021
teor2345
suggested changes
Nov 1, 2021
In newer versions of Tokio `Interval` doesn't implement `Stream`, so the wrapper types from `tokio-stream` have to be used instead.
In newer versions of Tokio the `Interval` type doesn't implement `Stream`, so `tokio_stream::wrappers::IntervalStream` has to be used instead.
In newer versions of Tokio `broadcast::Receiver` doesn't implement `Stream`, so `tokio_stream::wrappers::BroadcastStream` instead. This also requires changing the error type that is used.
jvff
force-pushed
the
use-tokio-stream-crate
branch
from
f172ab1 to
6e3df46
Compare
oxarbitrage
approved these changes
Nov 2, 2021
|
Merged through #2994. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is part of the update to use Tokio version 1 (#2200), and must be merged together with the other PRs.
Newer versions of Tokio have removed some
impl Streamfrom some types, so they have to either be used differently or have them wrapped in helper types from a separatetokio-streamcrate.Solution
Wrappers from the
tokio-streamcrate were used to fix a few usages of Tokio types that were previouslyStreams.Review
Anyone from the team can review this, but it shouldn't be merged yet.
Reviewer Checklist
Follow Up Work