Update Tokio to version 1.12.0 #2920
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
I added a testing section: In the tokio rollup PR, make sure that Zebra's dependency tree only has the upgraded tokio version. Also check for duplicates for other dependencies we upgraded. If we have multiple versions, we'll be running multiple executors, and might have other subtle bugs. We can check for duplicates using |
|
Note: the |
This was referenced Nov 1, 2021
Merged
This will break the build because the code isn't ready for the update, but future commits will fix the issues.
Use `futures::stream::StreamExt` instead, because newer versions of Tokio don't have the `stream` feature.
jvff
force-pushed
the
update-to-tokio-1.12.0
branch
from
becd6ca to
4fc5531
Compare
|
Merged through #2994. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is part of the update to use Tokio version 1 (#2200), and must be merged together with the other PRs.
Newer versions of Tokio have some interesting features, as well as unblocking Zebra from updating other dependencies.
Solution
The Tokio version was updated to 1.12.0. This unfortunately breaks the Zebra build, so this PR can't be merged until other PRs that fix the issues are approved.
One of the fixes is to not use the
StreamExttrait that was available in Tokio 0.3.6 but isn't available in Tokio 1.12.0. Some usages of that trait need some work, but one of the usages just needs to change the import so it was included in this PR.Review
Anyone from the team can review this, but it shouldn't be merged yet.
Testing
In the tokio rollup PR, make sure that Zebra's dependency tree only has the upgraded tokio version. Also check for duplicates for other dependencies we upgraded.
If we have multiple versions, we'll be running multiple executors, and might have other subtle bugs.
We can check for duplicates using
cargo deny check bans:https://embarkstudios.github.io/cargo-deny/checks/bans/index.html#use-case---duplicate-version-detection
Reviewer Checklist
Follow Up Work