Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Tower dependency to 0.4.9 #2918

Closed

Conversation

jvff
Copy link
Contributor

@jvff jvff commented Oct 20, 2021

Motivation

This is part of the update to use Tokio version 1 (#2200), and must be merged together with the other PRs.

The Tower crate has to be updated to a version that is compatible with the newer version of Tokio. No changes are actually necessary for the update. However, the ServiceExt::ready_and function became deprecated and that makes the build produce a lot of warnings.

Solution

The Tower dependency was updated to 0.4.9, which allows removal of the patched dependency. In order to remove all of the warnings, all usages of ServiceExt::ready_and were replaced with usages of ServiceExt::ready.

Review

Anyone from the team can review this PR, but it shouldn't be merged yet.

Reviewer Checklist

  • Code implements Specs and Designs
  • Tests for Expected Behaviour
  • Tests for Errors

Follow Up Work

@jvff jvff requested a review from a team October 20, 2021 19:48
@zfnd-bot zfnd-bot bot assigned jvff Oct 20, 2021
@jvff jvff force-pushed the update-tower-dependency-to-0.4.9 branch from e752911 to d531a90 Compare October 20, 2021 20:07
@dconnolly
Copy link
Contributor

Should this be pointed at #2920 as a base?

@jvff
Copy link
Contributor Author

jvff commented Oct 20, 2021

Should this be pointed at #2920 as a base?

I don't know how to change the base 😓

But it shouldn't matter I think, it will still depend on a few other PRs as well :/

@teor2345
Copy link
Contributor

I don't know how to change the base 😓

When you're editing the PR name, the base change menu is here:
Screen Shot 2021-10-21 at 08 44 33

But it shouldn't matter I think, it will still depend on a few other PRs as well :/

It only really matters when you have changes from multiple PRs in the GitHub diff.

Since we're not merging these PRs, we don't have to get the tests to pass, so it's not as important.

@jvff
Copy link
Contributor Author

jvff commented Oct 20, 2021

When you're editing the PR name, the base change menu is here:

Awesome, thanks!

Since we're not merging these PRs, we don't have to get the tests to pass, so it's not as important.

Ok, cool 👍

@mpguerra mpguerra mentioned this pull request Oct 29, 2021
10 tasks
@mpguerra mpguerra requested review from teor2345 and removed request for a team and teor2345 October 29, 2021 14:01
Copy link
Collaborator

@conradoplg conradoplg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seem good!This confirms that it's just a rename https://github.com/tower-rs/tower/releases/tag/tower-0.4.6

(I'm just taking a look so I'll leave approval for the reviewers assigned)

teor2345
teor2345 previously approved these changes Nov 1, 2021
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

@jvff jvff mentioned this pull request Nov 1, 2021
3 tasks
jvff added 2 commits November 2, 2021 00:32
Update to latest version to add support for Tokio version 1.
It was deprecated in favor of `ServiceExt::ready`.
@jvff jvff force-pushed the update-tower-dependency-to-0.4.9 branch from d531a90 to ba3c476 Compare November 2, 2021 00:34
@jvff jvff requested review from teor2345 and conradoplg November 2, 2021 01:17
Copy link
Contributor

@dconnolly dconnolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jvff
Copy link
Contributor Author

jvff commented Nov 2, 2021

Merged through #2994.

@jvff jvff closed this Nov 2, 2021
@jvff jvff deleted the update-tower-dependency-to-0.4.9 branch November 24, 2021 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants