-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Tower dependency to 0.4.9 #2918
Conversation
e752911
to
d531a90
Compare
Should this be pointed at #2920 as a base? |
I don't know how to change the base 😓 But it shouldn't matter I think, it will still depend on a few other PRs as well :/ |
Awesome, thanks!
Ok, cool 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seem good!This confirms that it's just a rename https://github.com/tower-rs/tower/releases/tag/tower-0.4.6
(I'm just taking a look so I'll leave approval for the reviewers assigned)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good.
Update to latest version to add support for Tokio version 1.
It was deprecated in favor of `ServiceExt::ready`.
d531a90
to
ba3c476
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Merged through #2994. |
Motivation
This is part of the update to use Tokio version 1 (#2200), and must be merged together with the other PRs.
The Tower crate has to be updated to a version that is compatible with the newer version of Tokio. No changes are actually necessary for the update. However, the
ServiceExt::ready_and
function became deprecated and that makes the build produce a lot of warnings.Solution
The Tower dependency was updated to 0.4.9, which allows removal of the patched dependency. In order to remove all of the warnings, all usages of
ServiceExt::ready_and
were replaced with usages ofServiceExt::ready
.Review
Anyone from the team can review this PR, but it shouldn't be merged yet.
Reviewer Checklist
Follow Up Work