Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Hyper to version 0.14 #2936

Closed
wants to merge 1 commit into from
Closed

Upgrade Hyper to version 0.14 #2936

wants to merge 1 commit into from

Conversation

jvff
Copy link
Contributor

@jvff jvff commented Oct 21, 2021

Motivation

This is part of the update to use Tokio version 1 (#2200), and must be merged together with the other PRs.

The previous version of hyper needs a runtime created by the older Tokio version. With the update to a newer version of Tokio, either an old runtime instance has to be spawned beside the new runtime, or the dependency on Hyper has to be updated to a version that supports the newer version of Tokio.

Solution

Update hyper to version 0.14, which supports the newer Tokio version.

Review

Reviewer Checklist

  • Code implements Specs and Designs
  • Tests for Expected Behaviour
  • Tests for Errors

Follow Up Work

Anyone from the team can review this, but it shouldn't be merged yet.

@jvff
Upgrade Hyper to version 0.14
38c8b4c 
Use a version that supports Tokio version 1.
@jvff jvff requested a review from a team October 21, 2021 22:08
@zfnd-bot zfnd-bot bot assigned jvff Oct 21, 2021
@jvff jvff mentioned this pull request Oct 21, 2021
Closed
3 tasks
@mpguerra mpguerra mentioned this pull request Oct 29, 2021
Closed
10 tasks
@mpguerra mpguerra requested review from oxarbitrage and removed request for a team October 29, 2021 14:04
oxarbitrage
oxarbitrage reviewed Oct 30, 2021
View reviewed changes
Copy link
Contributor

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine however hyper is used currently to open tracing and metric endpoint. Some acceptance tests are failing. In what PR is this fixed ? I think we should reference the two.

@jvff
Copy link
Contributor Author

jvff commented Nov 1, 2021

I think this is fine however hyper is used currently to open tracing and metric endpoint. Some acceptance tests are failing. In what PR is this fixed ? I think we should reference the two.

It is fixed by the PR to update metrics to 0.17: #2937.

@jvff jvff mentioned this pull request Nov 1, 2021
Merged
3 tasks
@jvff
Copy link
Contributor Author

jvff commented Nov 2, 2021

Merged through #2994.

@jvff jvff closed this Nov 2, 2021
@jvff jvff deleted the update-to-hyper-0.14 branch November 24, 2021 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxarbitrage oxarbitrage oxarbitrage approved these changes

Assignees

@jvff jvff

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jvff @oxarbitrage @teor2345