Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade tokio-util from 0.5.1 to 0.6.9 #2735

Closed
dconnolly opened this issue Sep 3, 2021 · 2 comments · Fixed by #2994
Closed

Upgrade tokio-util from 0.5.1 to 0.6.9 #2735

dconnolly opened this issue Sep 3, 2021 · 2 comments · Fixed by #2994
Assignees
@jvff
Labels
A-dependencies Area: Dependency file updates A-rust Area: Updates to Rust code
Milestone
2021 Sprint 21

Comments

@dconnolly
Copy link
Contributor

Motivation

0.6.* changes trait implementations for tokio::net::TcpStream breaking our builds:

image

https://github.com/ZcashFoundation/zebra/pull/2732/checks?check_run_id=3507380221
@dconnolly dconnolly added A-dependencies Area: Dependency file updates A-rust Area: Updates to Rust code P-Medium labels Sep 3, 2021
@dconnolly dconnolly mentioned this issue Sep 3, 2021
Closed
@mpguerra mpguerra added this to the 2021 Sprint 21 milestone Oct 13, 2021
@mpguerra
Copy link
Contributor

Do we need to do this one also as part of #2200 ?

@teor2345
Copy link
Contributor

Do we need to do this one also as part of #2200 ?

Yes, tokio-util 0.6.8 depends on tokio 1:
https://crates.io/crates/tokio-util/0.6.8/dependencies

But tokio-util 0.5.8 depends on tokio 0.3.4.

@mpguerra mpguerra added the S-blocked Status: Blocked on other tasks label Oct 18, 2021
@jvff jvff self-assigned this Oct 20, 2021
@jvff jvff mentioned this issue Nov 1, 2021
Merged
3 tasks
@teor2345 teor2345 changed the title Upgrade tokio-util from 0.5.1 to 0.6.8 Upgrade tokio-util from 0.5.1 to 0.6.9 Nov 1, 2021
@jvff jvff closed this as completed in #2994 Nov 2, 2021
@mpguerra mpguerra removed the S-blocked Status: Blocked on other tasks label Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jvff jvff

Labels
A-dependencies Area: Dependency file updates A-rust Area: Updates to Rust code
Projects
None yet
Milestone
2021 Sprint 21
Development

Successfully merging a pull request may close this issue.

Update to Tokio 1.13.0 jvff/zebra
4 participants
@dconnolly @mpguerra @jvff @teor2345