Update Sentry to version 0.23.0 #2954
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a version compatible with Tokio version 1.
This seems to not be available from `sentry-tracing` anymore, so it needs to be replaced.
This seems like the replacement for `TracingIntegration`.
teor2345
reviewed
Nov 1, 2021
Use a strict dependency specification.
jvff
force-pushed
the
update-to-sentry-0.23.0
branch
from
e3bf317 to
e3f82cb
Compare
teor2345
approved these changes
Nov 1, 2021
|
Merged through #2994. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is part of the update to use Tokio version 1 (#2200), and must be merged together with the other PRs.
The version of the
sentrycrate used by Zebra uses an older version of Tokio. In order to prune the dependency tree and avoid having multiple versions of the Tokio runtime running simultaneously, we should update thesentrydependency to a newer version that uses the same version of Tokio as Zebra.Solution
Update to
sentryversion 0.23.0. This requires some changes because theTracingIntegrationtype seems to no longer exist.Review
@dconnolly has worked with
sentrybefore and can review this, but it shouldn't be merged yet.Reviewer Checklist
Follow Up Work