add integration test for aid to join multisig #255
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #255 +/- ##
==========================================
- Coverage 82.85% 82.76% -0.10%
==========================================
Files 46 46
Lines 4189 4218 +29
Branches 1043 1053 +10
==========================================
+ Hits 3471 3491 +20
- Misses 689 722 +33
+ Partials 29 5 -24 ☔ View full report in Codecov by Sentry. |
|
I added the waitOperation call. Needs a new Keria image with WebOfTrust/keria#236 to make the tests pass. |
- add method in renaming credential registries. - update credential.test.ts Signed-off-by: arshdeep singh <[email protected]>
Signed-off-by: 2byrds <[email protected]>
…t#222) * fix: cannot set different salts for credential * fix types * add comments * fix dt for issuance event
* URL enconding of name in api call * prettier * content-lenght header not needed * add test * remove debris * fix test * pretty * Update test/app/aiding.test.ts
Signed-off-by: Nuttawut Kongsuwan <[email protected]>
maybe fix upload issue
* remove docs * add docs publish * fix permissions
|
I made some bad git-stuff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes multisig test join and illustrates the problem in #227.
The integration test creates a multisig-group with 2 members and threshold 1.
Member 1 adds a new member(member3) to the group and does a double rotation for the new member to be able to join and add the end-role by himself.